#5 xpad handles tray crash poorly

closed-fixed
nobody
None
5
2004-09-12
2004-09-11
No

If the systray crashes or is closed, then xpad doesn't
come back when the tray is recreated.

This code is a continuation of the habit of shamelessly
ripping things from Gaim. It adds a g_idle_add call
that will recreate the tray if the tray window is
destroyed for some odd reason.

I have a diff against the beta. I hope this helps.

Discussion

  • Andrew Sayman

    Andrew Sayman - 2004-09-11

    Logged In: YES
    user_id=111139

    I didn't make a very good argument for my patch, so I'll
    outline some steps to cause the bug previously and why I
    think it should be fixed.

    Steps to reproduce:
    1. Start a compliant dock app such as docker.
    2. Start xpad
    3. Kill docker
    4. Restart docker

    Expected results:
    The xpad tray icon will appear and you will be able to
    manipulate the program with it.

    Actual results:
    Nothing appears at all in the beta. This is better behavior
    than the previous version which displayed a blank spot that
    didn't respond to clicks.

    This happens for me a lot, because I swap around WMs a lot
    without killing X. This happens most when I transfer from
    XFCE4 to WindowMaker.

     
  • Michael Terry

    Michael Terry - 2004-09-12
    • status: open --> closed-fixed
     
  • Michael Terry

    Michael Terry - 2004-09-12

    Logged In: YES
    user_id=278278

    Thanks a bunch for the bug report and patch. You have good
    timing; I've added the patch to the current CVS and it's
    going in xpad-2.0-b2.

    Thanks again.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks