#37 theme selecter sort

Legacy 2.2 modules
closed-later
5
2011-03-13
2011-02-10
Anonymous
No

theme selecter sort
Does not depend on the order of the file system

1. html/modules/legacy/class/theme.php from line 85
[code]
foreach ($t_themeArr as $theme) {
$obj =& $this->create();
$obj->set('name', $theme->mName);
$obj->set('dirname', $theme->mDirname);
$obj->set('screenshot', $theme->mScreenShot);
$obj->set('description', $theme->mDescription);
$obj->set('format', $theme->mFormat);
$obj->set('render_system', $theme->mRenderSystemName);
$obj->set('version', $theme->mVersion);
$obj->set('author', $theme->mAuthor);
$obj->set('url', $theme->mUrl);
$obj->set('licence', $theme->mLicense);
$obj->set('license', $theme->mLicence);
$this->_mResults[] =& $obj;
unset($obj);
}
[/code]

to

[code]
foreach ($t_themeArr as $theme) {
$t_themeArr_temp[$theme->mDirname]['name']= $theme->mName;
$t_themeArr_temp[$theme->mDirname]['dirname']= $theme->mDirname;
$t_themeArr_temp[$theme->mDirname]['screenshot']= $theme->mScreenShot;
$t_themeArr_temp[$theme->mDirname]['description']= $theme->mDescription;
$t_themeArr_temp[$theme->mDirname]['format']= $theme->mFormat;
$t_themeArr_temp[$theme->mDirname]['render_system']= $theme->mRenderSystemName;
$t_themeArr_temp[$theme->mDirname]['version']= $theme->mVersion;
$t_themeArr_temp[$theme->mDirname]['author']= $theme->mAuthor;
$t_themeArr_temp[$theme->mDirname]['url']= $theme->mUrl;
$t_themeArr_temp[$theme->mDirname]['licence']= $theme->mLicense;
$t_themeArr_temp[$theme->mDirname]['license']= $theme->mLicence;
}
foreach($t_themeArr_temp as $row){
$dirname_arr[$row['dirname']] = $row['dirname'];
}
array_multisort($dirname_arr,SORT_ASC,$t_themeArr_temp);

foreach ($t_themeArr_temp as $key => $theme) {
$obj =& $this->create();
$obj->set('name', $theme['name']);
$obj->set('dirname', $theme['dirname']);
$obj->set('screenshot', $theme['screenshot']);
$obj->set('description', $theme['description']);
$obj->set('format', $theme['format']);
$obj->set('render_system', $theme['render_system']);
$obj->set('version', $theme['version']);
$obj->set('author', $theme['author']);
$obj->set('url', $theme['url']);
$obj->set('licence', $theme['licence']);
$obj->set('license', $theme['license']);
$this->_mResults[] =& $obj;
unset($obj);
}
[/code]

Discussion

  • HIKAWA Kilica

    HIKAWA Kilica - 2011-02-27

    I don't think this patch is worth application.
    I'll turn over the person of XCL2.3 or later.

     
  • HIKAWA Kilica

    HIKAWA Kilica - 2011-02-27
    • labels: --> Enhancement
    • milestone: --> Legacy 2.2 modules
    • assigned_to: nobody --> kilica
    • status: open --> pending-later
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending-later --> closed-later
     

Log in to post a comment.