#3 Bug of GroupMemberAction

0.9
closed-duplicate
minahito
None
9
2008-03-12
2007-06-08
wanikoo
No

mNoPageNavi doen't work properly!
(Just try to click page2 and you see you can't move to page2 properly)
Umm....
It can't handle prefix properly!
( $this->getStartKey() at fetchNaviControl() of class XCube_PageNavigator => "start" )
as you know, it should be "nostart"!
--;;??
Just temporary patch
from:
$this->mNoPageNavi=new XCube_PageNavigator("./index.php?action=GroupMember", XCUBE_PAGENAVI_START | XCUBE_PAGENAVI_PERPAGE); // TODO get controller->getUrl() ?
$this->mNoPageNavi->setTotalItems($total);
$this->mNoPageNavi->addExtra('groupid', $groupid);
$this->mNoPageNavi->setPrefix("no");
$this->mNoPageNavi->setPerpage(USER_GROUPMEMBER_DEFAULT_PERPAGE);
$this->mNoPageNavi->fetch();

$this->mNoUsers =& $memberHandler->getUsersByNoGroup($groupid, true, $this->mNoPageNavi->getPerpage(), $this->mNoPageNavi->getStart());

to:
$this->mNoPageNavi=new XCube_PageNavigator("./index.php?action=GroupMember", XCUBE_PAGENAVI_START | XCUBE_PAGENAVI_PERPAGE); // TODO get controller->getUrl() ?
$this->mNoPageNavi->setTotalItems($total);
$this->mNoPageNavi->addExtra('groupid', $groupid);
$this->mNoPageNavi->setPrefix("no");
$this->mNoPageNavi->setPerpage(USER_GROUPMEMBER_DEFAULT_PERPAGE);
$nostart = !empty($_REQUEST[$this->mNoPageNavi->mPrefix.'start']) ? intval($_REQUEST[$this->mNoPageNavi->mPrefix.'start']) : 0;
$this->mNoPageNavi->setStart($nostart);
$this->mNoPageNavi->fetch();

$this->mNoUsers =& $memberHandler->getUsersByNoGroup($groupid, true, $this->mNoPageNavi->getPerpage(), $this->mNoPageNavi->getStart());

Discussion

  • minahito

    minahito - 2007-06-11
    • status: open --> open-accepted
     
  • minahito

    minahito - 2007-06-23
    • milestone: 705996 --> 731538
    • assigned_to: nobody --> minahito
    • priority: 5 --> 7
     
  • minahito

    minahito - 2007-06-23

    Logged In: YES
    user_id=1102607
    Originator: NO

    This bug has been fixed in 2.1.0. By your report, I fixed a certain bug of XCube_PageNavigator. Perhaps, this item has been fixed in the same time, becase also the cause of this item is XCube_PageNavigator. I had to close this item in that time.

    Thank you very much.

    --
    Groups -> 2.1.0
    Resolution -> Fixed
    Status -> Closed

    In addition, I added 'fix bug' to dics/CHANGELOG(2.1.0).

     
  • minahito

    minahito - 2007-06-23
    • milestone: 731538 --> 705996
    • status: open-accepted --> closed-fixed
     
  • minahito

    minahito - 2007-06-24

    Logged In: YES
    user_id=1102607
    Originator: NO

    In Linux environments, this bug is confirmed. Re-Open.

     
  • minahito

    minahito - 2007-06-24
    • status: closed-fixed --> open-accepted
     
  • minahito

    minahito - 2007-06-24

    Logged In: YES
    user_id=1102607
    Originator: NO

    Moved to Bugs: XCube core.

     
  • minahito

    minahito - 2007-06-24
    • labels: 963737 -->
    • priority: 7 --> 9
    • milestone: 705996 -->
     
  • minahito

    minahito - 2007-12-22
    • milestone: --> 0.9
    • status: open-accepted --> open-duplicate
     
  • minahito

    minahito - 2007-12-22

    Logged In: YES
    user_id=1102607
    Originator: NO

    This bug might be fixed by Fix Bug #1852244.

     
  • minahito

    minahito - 2008-03-12
    • status: open-duplicate --> closed-duplicate
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks