You can find here an archive with modified file to add
a Color Picker element to XoopsFormElement.
Logged In: YES
I checked that and everything looks mostly ok for me.
Honnestly I don't like the script you grabbed so much, as
the use of a popup window makes it unresponsive and not so
much user-friendly, but after browsing around I couldn't
find any "ready-to-use" JS snippet that would be really
better, so that's not such a big problem in fact: this kind
of thing is small and we could always update the JS side
later to use an absolutely positionned div instead of a
popup, it wouldn't take ages.
A few details anyway:
- I started changing the files header comment format, please
use the new one for new files (there's an example in the
theme class file)
- You credited your work to "Kazumi Ono <www.zoullou.net>"
:S. This man took credit of other people work enough already
in his time, there's no need to continue this by tradition.
Generally speaking: in a file you completely wrote like
here, the only name that should appear is yours (or maybe
here it would have been good to say "this element uses the
tigra colorpicker blah blah" even if the credits are already
in the js file)
- As you made the colorpicker class a children of
XoopsFormText, there was no need to duplicate the text
element rendering code here. It would have been better to do
return parent::render() . "<input type='reset' value=' ...
Otherwise, it's always nice to see some people can
understand by themselves what some of the new features like
the theme class have been added for, so thanks for that :-)
Logged In: YES
Thanks for your replie.
For Credit, it's a mistake because i take XoopsFormDateTime
for exemple but in this file there are 2 credit part, i
don't delete the right one :-)
I will try to send you an update version with div position.
Moreover, i fixed a bug because on admin side,
$GLOBALS['xoTheme'] isn't defined (no theme on admin side).
admin side. It isn't XHTML complient but i didn't find a
solution to add this script on header.
When you plan to distribute this feature with next XOOPS
version. I would know the time that i have to make
I have updated the archive. Some bugs are fixed and a diff
patch is provided.
Applied to the 2.0.15 branch and the trunk.
Thanks for helping up making XOOPS better :-)
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.