Menu
▾
▴
[Xoops-trackers] [ xoops-Bugs-1054221 ] xoops_module_header can not be cached
|
From: SourceForge.net <no...@so...> - 2005-04-08 16:52:18
|
Bugs item #1054221, was opened at 2004-10-26 01:46 Message generated for change (Comment added) made by mithyt2 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=430840&aid=1054221&group_id=41586 Category: Core - Core Group: XOOPS 2.2.x >Status: Closed Resolution: Fixed Priority: 5 Submitted By: phppp (phppp) Assigned to: Jan Pedersen (mithyt2) Summary: xoops_module_header can not be cached Initial Comment: The "xoops_module_header" is assigned in each module instead of in the xoops/header.php and it is not be cached. Will this be fixed in 2.09 or shall we state in the NewBB2 release that 'do not use cache for NewBB2'? the newbb.css could be moved to xoops.css or themes/style.css, but how about the newbb.js? Even this could be done, I would guess users prefer a core fix. ---------------------------------------------------------------------- >Comment By: Jan Pedersen (mithyt2) Date: 2005-04-08 18:52 Message: Logged In: YES user_id=841117 The code has now been committed to the Xoops2_1_0-branch-new CVS branch ---------------------------------------------------------------------- Comment By: Jan Pedersen (mithyt2) Date: 2005-04-03 18:58 Message: Logged In: YES user_id=841117 In the xoops2_1_0-branch-new CVS branch, I will soon commit some code, I have done and am testing at the moment. The $xoopsTpl instantiation is moved to include/common.php which means that you can use $xoopsTpl->assign() _before_ including header.php, thus allowing xoops_module_header and custom page titles also on cached pages. The administration area will also use the theme... Working nicely, just need a couple of things more, then I'll commit it. ---------------------------------------------------------------------- Comment By: Jan Pedersen (mithyt2) Date: 2005-03-25 13:33 Message: Logged In: YES user_id=841117 OK, I'll take care of this one personally. ---------------------------------------------------------------------- Comment By: Dominic Ryan (brashquido) Date: 2004-11-18 04:30 Message: Logged In: YES user_id=842809 Any updates on this issue? ---------------------------------------------------------------------- Comment By: phppp (phppp) Date: 2004-10-26 15:30 Message: Logged In: YES user_id=1001493 Good. And also make the xoopsOption for other variables so that each individual module can customize the header content, for instance, the pagetitle hack could be cached. ---------------------------------------------------------------------- Comment By: Jan Pedersen (mithyt2) Date: 2004-10-26 09:56 Message: Logged In: YES user_id=841117 Right - it is not a working solution to assign the module_header after the inclusion of header.php Instead I think it would be best to set a $xoopsOption['xoops_module_header'] before including header.php (like with the $xoopsOption['template_main']) I'll be sure to discuss this with the others, how we can do this best. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=430840&aid=1054221&group_id=41586 |