[xoops-svn] SF.net SVN: xoops-svn:[12332] XoopsCore/branches/2.5.x/2.5.7

[<be...@us...>]

Revision: 12332
          http://sourceforge.net/p/xoops/svn/12332
Author:   beckmi
Date:     2014-02-25 00:34:43 +0000 (Tue, 25 Feb 2014)
Log Message:
-----------
fixed PHP minimum version comparison in ModuleAdmin

Modified Paths:
--------------
    XoopsCore/branches/2.5.x/2.5.7/docs/changelog.250.txt
    XoopsCore/branches/2.5.x/2.5.7/htdocs/Frameworks/moduleclasses/moduleadmin/moduleadmin.php

Modified: XoopsCore/branches/2.5.x/2.5.7/docs/changelog.250.txt
===================================================================
--- XoopsCore/branches/2.5.x/2.5.7/docs/changelog.250.txt	2014-02-24 10:31:01 UTC (rev 12331)
+++ XoopsCore/branches/2.5.x/2.5.7/docs/changelog.250.txt	2014-02-25 00:34:43 UTC (rev 12332)
@@ -63,6 +63,7 @@
 - updated required PHP and XOOPS versions, module versions in modules (cesag/mamba)
 - added xBootstrap theme (UI/UX Team: Angelo Roja, Bleekk, Heyula)
 - added extra escape for "e" in YESTERDAY definition in locale.php, which was added in PHP 5.4 (madDan)
+- fixed PHP minimum version comparison in ModuleAdmin (mamba)
 
 Security fixes
 - XSS issues reported by Mehdi Dadkhah (rgriffith)

Modified: XoopsCore/branches/2.5.x/2.5.7/htdocs/Frameworks/moduleclasses/moduleadmin/moduleadmin.php
===================================================================
--- XoopsCore/branches/2.5.x/2.5.7/htdocs/Frameworks/moduleclasses/moduleadmin/moduleadmin.php	2014-02-24 10:31:01 UTC (rev 12331)
+++ XoopsCore/branches/2.5.x/2.5.7/htdocs/Frameworks/moduleclasses/moduleadmin/moduleadmin.php	2014-02-25 00:34:43 UTC (rev 12332)
@@ -262,8 +262,8 @@
 
             // php version
             $path = XOOPS_URL . "/Frameworks/moduleclasses/icons/16/";
-            if ($this->_obj->getInfo('min_php')) {
-                if (phpversion() < $this->_obj->getInfo('min_php')) {
+            if ($this->_obj->getInfo('min_php')) {                
+                if (version_compare(phpversion(), $this->_obj->getInfo('min_php'), '<')) {
                     $ret .= "<span style='color : red; font-weight : bold;'><img src='" . $path . "0.png' >" . sprintf(_AM_MODULEADMIN_CONFIG_PHP, $this->_obj->getInfo('min_php'), phpversion()) . "</span>\n";
                 } else {
                     $ret .= "<span style='color : green;'><img src='" . $path . "1.png' >" . sprintf(_AM_MODULEADMIN_CONFIG_PHP, $this->_obj->getInfo('min_php'), phpversion()) . "</span>\n";