Menu
▾
▴
[xoops-svn] SF.net SVN: xoops-svn:[11969] XoopsModules/newbb/branches/irmtfan/newbb
|
From: <be...@us...> - 2013-08-24 08:53:36
|
Revision: 11969
http://sourceforge.net/p/xoops/svn/11969
Author: beckmi
Date: 2013-08-24 08:53:30 +0000 (Sat, 24 Aug 2013)
Log Message:
-----------
bug fix: single quotes inside language definitions break onClick event
Modified Paths:
--------------
XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt
XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_index.html
XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_thread.html
XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewall.html
XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewtopic.html
XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_index.html
XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_thread.html
XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewall.html
XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewtopic.html
Modified: XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt 2013-08-24 08:53:30 UTC (rev 11969)
@@ -1,6 +1,7 @@
-date 2013-08-15
+date 2013-08-24
===================================
-1- bug fix: check if xoops poll module is available in newbb/admin/index.php (Cesag)
+1- bug fix: check if xoops poll module is available in newbb/admin/index.php (Cesag)
+2- bug fix: single quotes inside language definitions break onClick event (Cesag/Irmtfan/Mamba)
date 2013-05-28
===================================
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_index.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_index.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_index.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -45,7 +45,7 @@
<tr class="head">
<td width="3%" valign="middle" align="center">
<!-- irmtfan simplify onclick method and use newbb_displayImage(this.children[0] for IE7&8) - add alt and title"-->
- <div class="pointer" onclick="ToggleBlockCategory('<{$category.cat_element_id}>',(this.firstElementChild || this.children[0]) , '<{$category_icon.expand}>', '<{$category_icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE}>','<{$smarty.const._MD_NEWBB_SEE}>')">
+ <div class="pointer" onclick="ToggleBlockCategory('<{$category.cat_element_id}>',(this.firstElementChild || this.children[0]) , '<{$category_icon.expand}>', '<{$category_icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE|escape:'quotes'}>','<{$smarty.const._MD_NEWBB_SEE|escape:'quotes'}>')">
<{$category.cat_displayImage}>
</div>
</td>
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_thread.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_thread.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_thread.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -45,7 +45,7 @@
<br />
<{if $infobox.show}>
<!-- irmtfan simplify onclick method (this.children[0] for IE7&8) - remove hardcode style="padding:2px;"-->
- <span class="pointer" onclick="ToggleBlockCategory('<{$topic_post.post_id}>',(this.firstElementChild || this.children[0]) , '<{$infobox.icon.expand}>', '<{$infobox.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDEUSERDATA}>','<{$smarty.const._MD_NEWBB_SEEUSERDATA}>')">
+ <span class="pointer" onclick="ToggleBlockCategory('<{$topic_post.post_id}>',(this.firstElementChild || this.children[0]) , '<{$infobox.icon.expand}>', '<{$infobox.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDEUSERDATA|escape:'quotes'}>','<{$smarty.const._MD_NEWBB_SEEUSERDATA|escape:'quotes'}>')">
<{$infobox.displayImage}>
</span>
<!-- irmtfan move semicolon -->
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewall.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewall.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewall.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -99,7 +99,7 @@
</td></tr></table>
</div>
<script type="text/javascript">document.getElementById("topicoption").onmouseout = closeMenu;</script>
- <div class="menubar"><a href="" onclick="openMenu(event, 'topicoption');return false;"><{$smarty.const._MD_TOPICOPTION}></a></div>
+ <div class="menubar"><a href="" onclick="openMenu(event, 'topicoption');return false;"><{$smarty.const._MD_TOPICOPTION|escape:'quotes'}></a></div>
<{elseif $menumode eq 2}>
<div class="menu">
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewtopic.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewtopic.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates/newbb_viewtopic.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -237,7 +237,7 @@
<{if $quickreply.show}>
<div>
<!-- irmtfan improve toggle method to ToggleBlockCategory (this.children[0] for IE7&8) change display to style and icon to displayImage for more comprehension -->
- <a href="#threadbottom" onclick="ToggleBlockCategory('qr', (this.firstElementChild || this.children[0]), '<{$quickreply.icon.expand}>', '<{$quickreply.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE}> <{$smarty.const._MD_QUICKREPLY}>','<{$smarty.const._MD_NEWBB_SEE}> <{$smarty.const._MD_QUICKREPLY}>')" >
+ <a href="#threadbottom" onclick="ToggleBlockCategory('qr', (this.firstElementChild || this.children[0]), '<{$quickreply.icon.expand}>', '<{$quickreply.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE|escape:'quotes'}> <{$smarty.const._MD_QUICKREPLY|escape:'quotes'}>','<{$smarty.const._MD_NEWBB_SEE|escape:'quotes'}> <{$smarty.const._MD_QUICKREPLY|escape:'quotes'}>')" >
<{$quickreply.displayImage}>
</a>
</div>
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_index.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_index.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_index.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -38,7 +38,7 @@
<!-- start forum categories -->
<{foreachq item=category from=$categories}>
<div class="head align_center">
- <div class="pointer floatleft" onclick="ToggleBlockCategory('<{$category.cat_element_id}>',(this.firstElementChild || this.children[0]) , '<{$category_icon.expand}>', '<{$category_icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE}>','<{$smarty.const._MD_NEWBB_SEE}>','toggle_block','toggle_none');">
+ <div class="pointer floatleft" onclick="ToggleBlockCategory('<{$category.cat_element_id}>',(this.firstElementChild || this.children[0]) , '<{$category_icon.expand}>', '<{$category_icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE|escape:'quotes'}>','<{$smarty.const._MD_NEWBB_SEE|escape:'quotes'}>','toggle_block','toggle_none');">
<{$category.cat_displayImage}>
</div>
<{if $category.cat_image}>
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_thread.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_thread.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_thread.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -26,7 +26,7 @@
<{/if}>
<{if $infobox.show}>
<br />
- <span class="pointer" onclick="ToggleBlockCategory('toggle-<{$topic_post.post_id}>',(this.firstElementChild || this.children[0]) , '<{$infobox.icon.expand}>', '<{$infobox.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDEUSERDATA}>','<{$smarty.const._MD_NEWBB_SEEUSERDATA}>','toggle_block','toggle_none');">
+ <span class="pointer" onclick="ToggleBlockCategory('toggle-<{$topic_post.post_id}>',(this.firstElementChild || this.children[0]) , '<{$infobox.icon.expand}>', '<{$infobox.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDEUSERDATA|escape:'quotes'}>','<{$smarty.const._MD_NEWBB_SEEUSERDATA|escape:'quotes'}>','toggle_block','toggle_none');">
<{$infobox.displayImage}>
</span>
<div id="toggle-<{$topic_post.post_id}>" class="toggle_<{$infobox.style}>">
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewall.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewall.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewall.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -85,7 +85,7 @@
<div class="clear"></div>
</div>
<script type="text/javascript">document.getElementById("topicoption").onmouseout = closeMenu;</script>
- <div class="menubar"><a href="" onclick="openMenu(event, 'topicoption');return false;"><{$smarty.const._MD_TOPICOPTION}></a></div>
+ <div class="menubar"><a href="" onclick="openMenu(event, 'topicoption');return false;"><{$smarty.const._MD_TOPICOPTION|escape:'quotes'}></a></div>
<{elseif $menumode eq 2}>
<div class="menu">
<ul>
Modified: XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewtopic.html
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewtopic.html 2013-08-24 07:36:27 UTC (rev 11968)
+++ XoopsModules/newbb/branches/irmtfan/newbb/templates_fulldiv_opacity/newbb_viewtopic.html 2013-08-24 08:53:30 UTC (rev 11969)
@@ -209,7 +209,7 @@
<{if $quickreply.show}>
<div>
- <a href="#threadbottom" onclick="ToggleBlockCategory('qr', (this.firstElementChild || this.children[0]), '<{$quickreply.icon.expand}>', '<{$quickreply.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE}> <{$smarty.const._MD_QUICKREPLY}>','<{$smarty.const._MD_NEWBB_SEE}> <{$smarty.const._MD_QUICKREPLY}>','toggle_block','toggle_none');" >
+ <a href="#threadbottom" onclick="ToggleBlockCategory('qr', (this.firstElementChild || this.children[0]), '<{$quickreply.icon.expand}>', '<{$quickreply.icon.collapse}>','<{$smarty.const._MD_NEWBB_HIDE|escape:'quotes'}> <{$smarty.const._MD_QUICKREPLY|escape:'quotes'}>','<{$smarty.const._MD_NEWBB_SEE|escape:'quotes'}> <{$smarty.const._MD_QUICKREPLY|escape:'quotes'}>','toggle_block','toggle_none');" >
<{$quickreply.displayImage}>
</a>
</div>
|
