[xoops-svn] SF.net SVN: xoops-svn:[10257] XoopsModules/newbb/branches/irmtfan/newbb

[<ir...@us...>]

Revision: 10257
          http://sourceforge.net/p/xoops/svn/10257
Author:   irmtfan
Date:     2012-11-19 07:18:31 +0000 (Mon, 19 Nov 2012)
Log Message:
-----------
bug fix: moderator have all access over forum regardless of his/her group access

Modified Paths:
--------------
    XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt
    XoopsModules/newbb/branches/irmtfan/newbb/class/forum.php

Modified: XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt	2012-11-18 22:32:49 UTC (rev 10256)
+++ XoopsModules/newbb/branches/irmtfan/newbb/changelog-rev10109.txt	2012-11-19 07:18:31 UTC (rev 10257)
@@ -1,3 +1,8 @@
+date 2012-11-19
+===================================
+1- bug fix: in viewforum.php?forum=XXX . moderator have all access over the forum regardless of his/her group access.
+in newbb/class/forum.php
+
 date 2012-11-14
 ===================================
 1- feature add: add pdf and print permissions. fix html and signature permission in new install.

Modified: XoopsModules/newbb/branches/irmtfan/newbb/class/forum.php
===================================================================
--- XoopsModules/newbb/branches/irmtfan/newbb/class/forum.php	2012-11-18 22:32:49 UTC (rev 10256)
+++ XoopsModules/newbb/branches/irmtfan/newbb/class/forum.php	2012-11-19 07:18:31 UTC (rev 10257)
@@ -555,9 +555,12 @@
         static $_cachedPerms;
 
         if ($type == "all") return true;
-        if ($GLOBALS["xoopsUserIsAdmin"] && $xoopsModule->getVar("dirname") == "newbb") {
-            return true;
-        }
+        // irmtfan - if user is forum moderator then return true
+		mod_loadFunctions("user", "newbb");
+        if (newbb_isAdmin($forum)) return true;
+        //if ($GLOBALS["xoopsUserIsAdmin"] && $xoopsModule->getVar("dirname") == "newbb") {
+            //return true;
+        //}
         
         if (!is_object($forum)) $forum =& $this->get($forum);
 
@@ -568,14 +571,16 @@
         }
 
         $type = strtolower($type);
-        if ("moderate" == $type) {
-            require_once XOOPS_ROOT_PATH . "/modules/newbb/include/functions.user.php";
-            $permission = newbb_isModerator($forum);
-        } else {
+        // START irmtfan commented and removed
+        //if ("moderate" == $type) {
+            //require_once XOOPS_ROOT_PATH . "/modules/newbb/include/functions.user.php";
+            //$permission = newbb_isModerator($forum);
+        //} else {
             $forum_id = $forum->getVar('forum_id');
             $perm_handler =& xoops_getmodulehandler('permission', 'newbb');
             $permission = $perm_handler->getPermission("forum", $type, $forum_id);
-        }
+        //}
+        // END irmtfan commented and removed
         return $permission;
     }