[xoops-svn] SF.net SVN: xoops:[10163] XoopsCore/branches/2.6.x/2.6.0/htdocs/modules/ profile/search.php

[<ma...@us...>]

Revision: 10163
          http://xoops.svn.sourceforge.net/xoops/?rev=10163&view=rev
Author:   mageg
Date:     2012-09-09 16:55:00 +0000 (Sun, 09 Sep 2012)
Log Message:
-----------
Fixed bug ID: 3562232

Modified Paths:
--------------
    XoopsCore/branches/2.6.x/2.6.0/htdocs/modules/profile/search.php

Modified: XoopsCore/branches/2.6.x/2.6.0/htdocs/modules/profile/search.php
===================================================================
--- XoopsCore/branches/2.6.x/2.6.0/htdocs/modules/profile/search.php	2012-09-09 16:40:18 UTC (rev 10162)
+++ XoopsCore/branches/2.6.x/2.6.0/htdocs/modules/profile/search.php	2012-09-09 16:55:00 UTC (rev 10163)
@@ -339,14 +339,21 @@
             }
         }
 
-        if ($_REQUEST['sortby'] == "name") {
-            $criteria->setSort("name");
-        } else if ($_REQUEST['sortby'] == "email") {
-            $criteria->setSort("email");
-        } else if ($_REQUEST['sortby'] == "uname") {
-            $criteria->setSort("uname");
-        } else if (isset($fields[$_REQUEST['sortby']])) {
-            $criteria->setSort($fields[$_REQUEST['sortby']]->getVar('field_name'));
+        $sortby = 'uname';
+        if (!empty($_REQUEST['sortby'])) {
+            switch ($_REQUEST['sortby']) {
+                case 'name':
+                case 'email':
+                case 'uname':
+                    $sortby = $_REQUEST['sortby'];
+                    break;
+                default:
+                    if (isset($fields[$_REQUEST['sortby']])) {
+                        $sortby = $fields[$_REQUEST['sortby']]->getVar('field_name');
+                    }
+                    break;
+            }
+            $criteria->setSort($sortby);
         }
 
         // add search groups , only for Webmasters
@@ -401,7 +408,7 @@
         if ($total_users > $limit) {
             $search_url[] = "op=results";
             $search_url[] = "order=" . $order;
-            $search_url[] = "sortby=" . htmlspecialchars($_REQUEST['sortby']);
+            $search_url[] = "sortby=" . htmlspecialchars($sortby);
             $search_url[] = "limit=" . $limit;
             if (isset($search_url)) {
                 $args = implode("&", $search_url);

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.