[xoops-svn] SF.net SVN: xoops:[9789] XoopsModules/newbb/branches/alfred/newbb/ topicmanager.php

[<dh...@us...>]

Revision: 9789
          http://xoops.svn.sourceforge.net/xoops/?rev=9789&view=rev
Author:   dhcst
Date:     2012-07-04 20:50:55 +0000 (Wed, 04 Jul 2012)
Log Message:
-----------
fix fatal error when forenid=0

Modified Paths:
--------------
    XoopsModules/newbb/branches/alfred/newbb/topicmanager.php

Modified: XoopsModules/newbb/branches/alfred/newbb/topicmanager.php
===================================================================
--- XoopsModules/newbb/branches/alfred/newbb/topicmanager.php	2012-07-04 20:20:34 UTC (rev 9788)
+++ XoopsModules/newbb/branches/alfred/newbb/topicmanager.php	2012-07-04 20:50:55 UTC (rev 9789)
@@ -46,7 +46,9 @@
 
 if ( !$topic_id ) {
 	$redirect = empty($forum_id)? "index.php" : "viewforum.php?forum={$forum}";
+	$redirect = XOOPS_URL . "/modules/newbb/" . $redirect;
     redirect_header($redirect, 2, _MD_ERRORTOPIC);
+	exit();
 }
 
 $topic_handler =& xoops_getmodulehandler('topic', 'newbb');
@@ -54,7 +56,13 @@
 
 if ( !$forum ) {
 	$topic_obj =& $topic_handler->get(intval($topic_id));	
-    $forum = $topic_obj->getVar("forum_id");
+	if (is_object($topic_obj)) {
+		$forum = $topic_obj->getVar("forum_id");
+	} else {
+		$redirect = XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=" . $topic_id;
+		redirect_header($redirect, 2, _MD_FORUMNOEXIST);
+		exit();
+	}
 	unset($topic_obj);
 }
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.