[xoops-svn] SF.net SVN: xoops:[8790] XoopsModules/smallworld/trunk/smallworld

[<dj...@us...>]

Revision: 8790
          http://xoops.svn.sourceforge.net/xoops/?rev=8790&view=rev
Author:   djculex
Date:     2012-01-23 13:15:30 +0000 (Mon, 23 Jan 2012)
Log Message:
-----------
bugfix: check if array is empty before counting it (duh!)
bugfix: Date of first message only set if any messages exists (double duh!)

Modified Paths:
--------------
    XoopsModules/smallworld/trunk/smallworld/admin/index.php
    XoopsModules/smallworld/trunk/smallworld/class/adminclass.php

Modified: XoopsModules/smallworld/trunk/smallworld/admin/index.php
===================================================================
--- XoopsModules/smallworld/trunk/smallworld/admin/index.php	2012-01-23 12:46:42 UTC (rev 8789)
+++ XoopsModules/smallworld/trunk/smallworld/admin/index.php	2012-01-23 13:15:30 UTC (rev 8790)
@@ -35,7 +35,13 @@
 $admin = new SmallworldAdmin();
 
 // Find oldest message and apply to template
-$dateoffirstmessage = date(_SHORTDATESTRING, $admin->oldestMsg());
+$dfm = $admin->oldestMsg();
+if ($dfm==0) {
+	$dfm = _AM_SMALLWORLD_NONEYET;
+} else {
+	$dfm = date(_SHORTDATESTRING, $admin->oldestMsg());
+}
+$dateoffirstmessage = $dfm;
 
 // Get days number
 $totaldays = $admin->CountDays();
@@ -93,7 +99,11 @@
 
 // FInd list of best rated users overall
 $topusers = $admin->topratedusers('up');
+if (!empty($topusers)){
 $count = count($topusers['cnt']);
+} else {
+$count = 0;
+}
 $top_cnt = 0;
 	if ($count != 0) {
 		$top_cnt = 1;
@@ -115,7 +125,11 @@
 // FInd list of worst rated users overall
 $lowusers = $admin->topratedusers('down');
 $low_cnt = 0;
+if (!empty($lowusers)) {
 $count = count($lowusers['cnt']);
+} else {
+$count=0;
+}
 	if ($count != 0) {
 		$low_cnt = 1;
 		$low = "<table class='smallworldadmin'><tr>";

Modified: XoopsModules/smallworld/trunk/smallworld/class/adminclass.php
===================================================================
--- XoopsModules/smallworld/trunk/smallworld/class/adminclass.php	2012-01-23 12:46:42 UTC (rev 8789)
+++ XoopsModules/smallworld/trunk/smallworld/class/adminclass.php	2012-01-23 13:15:30 UTC (rev 8790)
@@ -24,12 +24,14 @@
 	// Get oldes message in Db
 	function oldestMsg () {
 		global $xoopsDB;
+		$date = 0;
 		$sql = "SELECT * FROM ".$xoopsDB->prefix('smallworld_messages')." ORDER BY created limit 1";
 		$result = $xoopsDB->queryF($sql);
 		$counter = $xoopsDB->getRowsNum($result);
-		if ($counter < 1) {$date = _AM_SMALLWORLD_NONEYET;}
-		while ($sqlfetch = $xoopsDB->fetchArray($result)) {
-		 $date = $sqlfetch['created'];
+		if ($counter >= 1) {	 
+			while ($sqlfetch = $xoopsDB->fetchArray($result)) {
+			 $date = $sqlfetch['created'];
+			}
 		}
 			return $date;
 	}

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.