Menu

#19 LDFLAGS are not used

1.0
closed
nobody
None
2022-01-24
2022-01-24
No

The build system should honor LDFLAGS from environment.

Proposed patch:

--- source/Makefile.common.orig 2022-01-09 12:28:40.000000000 +0000
+++ source/Makefile.common
@@ -21,11 +21,11 @@ all: xnedit xnc
 xnedit: $(OBJS) ../util/libNUtil.a $(XMLLIB) $(XLTLIB)
    $(CC) $(CFLAGS) -c linkdate.c -o linkdate.o
    $(CC) $(CFLAGS) $(OBJS) linkdate.o \
-    ../util/libNUtil.a $(XMLLIB) $(XLTLIB) $(LIBS) -o $@
+    ../util/libNUtil.a $(LDFLAGS) $(XMLLIB) $(XLTLIB) $(LIBS) -o $@

 # Note LIBS isn't quite right here; it links unnecessarily against Motif
 xnc: nc.o server_common.o ../util/libNUtil.a
-   $(CC) $(CFLAGS) nc.o server_common.o ../util/libNUtil.a $(LIBS) -o $@
+   $(CC) $(CFLAGS) nc.o server_common.o ../util/libNUtil.a $(LDFLAGS) $(LIBS) -o $@

 help.o: help.c
    $(CC) $(CFLAGS) $(BIGGER_STRINGS) -c help.c -o $@

Discussion

  • Pyrphoros

    Pyrphoros - 2022-01-24
    • status: open --> closed
     
  • Pyrphoros

    Pyrphoros - 2022-01-24

    patch applied

     

Log in to post a comment.