Re: [XNap-Commons-Devel] Re: FileChooserPanel enhancement

[Felix B. <bf...@gm...>]

On Tuesday 07 June 2005 01:15 pm, you wrote:
> Sorry, my refactoring is not so good. How about this new one?
> http://sqs.cmr.sfc.keio.ac.jp/tdiary/files/xnap-commons-20050608-FileChoose
>rPanel.patch

Proposition: Instead of allowing to create your own action, just provide a 
protected method in FileChooserPanel which is called by the FileChooserAction 
in its actionPerformed method. This way the action's text and icon is always 
persistent. See DefaultDialog for a similar pattern.

I'd still be interested to know why you would like to subclass the action, 
maybe this would help me better understand your motivation.

> This patch contains a new feature of sorting FileCompletion list by
> filename.

Sounds cool, we just have to make sure it doesn't become too slow, after all 
completion is completely handled in the gui thread right now, and for some 
modes this cannot be changed easily.

Thanks for your contributions,
Felix