From: KUBO H. <hi...@sf...> - 2005-06-07 17:15:23
|
Hi, Flex. Felix Berger wrote: > > Just out of curiosity how did you learn about XNap Commons? I googled by keyword "ClosableTabbedPane" then I found XNap Commons. There are may implementations of ClosableTabbedPane, but most of their software licenses are not free or not clearly defined. > I had a look at your patch. It looks decent and extends the FileChooserPanel > nicely. Thanx. > A few remarks: > > * I did not quite understand the need for the abstract filechooser action, why > and how would you overwrite it? Since the action is an inner class it can > retrieve the selection mode from the FileChooserPanel, so there is no need to > store that information itself. How do you install a different implementation > of the action into the panel? Sorry, my refactoring is not so good. How about this new one? http://sqs.cmr.sfc.keio.ac.jp/tdiary/files/xnap-commons-20050608-FileChooserPanel.patch This patch contains a new feature of sorting FileCompletion list by filename. KUBO Hiroya hi...@sf... |