Re: [XNap-Commons-Devel] Re: FileChooserPanel enhancement

[Felix B. <bf...@gm...>]

Hi Hiroya,

I had a look at your patch. It looks decent and extends the FileChooserPanel 
nicely.

A few remarks:

* Maybe we could reuse the constants from JFileChooser, otherwise they should 
be documented.

* I did not quite understand the need for the abstract filechooser action, why 
and how would you overwrite it? Since the action is an inner class it can 
retrieve the selection mode from the FileChooserPanel, so there is no need to 
store that information itself. How do you install a different implementation 
of the action into the panel?

Regards,
Felix