Re: [Xmpppy-devel] code comprehension

[oboe <ob...@en...>]

On Thu, Sep 30, 2004 at 08:14:19AM +0400, Alexey Nezhdanov wrote:
> > > > > confusing code.
> > I still stand by my statement (:
> > Since you write no documentation, can you at least add a couple simple
> > comments as you go? I'd like to help, but your code is not the :most: self
> > explanitory. Python is not my first language.
> I have nothing to complain. The xmppd.py project targets for several goals and 
> "well-documented" is among them. I'll try to start acheving it.
> 
I see that someone has brought this up in the past, I dont want to be a pain and just complain more. (: I'm more than interested in helping where I can, at the moment, my understanding of your code isnt knowledgable enough to be of any aid.

I would encourage you to take a look at strogge's "newsbot" project on JabberStudio (http://jabberstudio.org/projects/newsbot/project/view.php). Also, you might consider putting xmpp/xmppd on Temas' JabberStudio site rather than SF.

Strogge manages to use a combination of insightful comments, at a minimum, along with well chosen object/variable/function names. The code is fairly self documenting that way. I understand you prefer tight code, but one letter variable names are counterproductive for future readability. (:

I am very much interested in writing some extensions to your bare bones xmppd server, once I get a grasp of how it is layed out, and how best to hack in feature stubs. I hope my "complaints" dont discourage you! Keep up the work, the jabber community needs more dedicated coders like you. 

> > >
> > > Probably you are using xmppd.py with old xmpppy library. Try using
> > > version, included in xmppd.tar.gz package.
> >
> > Actually, I'm making the assumption that cvs mainline is :basically:
> > functional code.
> My main CVS repository resides on my hard disk because of too slow channel to 
> SF from my home (actually a very busy 9600bps link). So SF's CVS check ins 
> are rare now and xmppd.py and xmpppy reposytoryes are out-of-sync sometimes.
> The nxvoc feature was added to xmpppy code just before xmppd-0.1 release and 
> then I've considered it harmful and removed it.
>
So this means your dev code is on your local machine (jeez, make backups!)and at stable points you commit up to the SF cvs server?

I'll grab a tarball for now and play with it. A CHANGES or NOTES file might be of some help, if you can note which features you add as you go, and checkout cvs to make tarballs. 


Thanks!
-=C=-