#7 window toggles don't work as expected

[Eric Agnew]

Using the 'window X toggle' function does not work as
expected. The main problem is that doing a toggle on
any window will automatically cause ALL other windows
to be shown, whether they were or not before. So, if I
have the main window open and the EQ and playlists
closed, and do "xmms-shell -e 'window playlist
toggle'", both the playlist AND the EQ window will
appear. Running the same command again will hide the
playlist window, but the EQ window will remain open.
Similarly, if ALL windows are hidden, running a toggle
on any window will cause them all to appear. If the
main and playlist windows are open and 'window playlist
toggle' is performed, the playlist will toggle, but the
EQ window will appear.

Further, running 2 commands sequentially to "fix" this
problem, i.e. "xmms-shell -e 'window playlist toggle';
xmms-shell -e 'window equalizer hide'" has even weirder
behavior (is this a "race condition"?)- sometimes both
windows will pop up and then disappear instantly,
sometimes both will remain open, and sometimes the
playlist will open and the EQ disappear, as expected.
Putting a 'sleep 1' between these two commands seems to
give it enough time to work properly, but is an
annoying side effect if the point is to try to toggle
the playlist alone w/ a hotkey.

This is with debian/unstable packages xmms 1.2.7-1.1
and xmms-shell 0.99.2-1.

[Ansgar Burchardt]

Logged In: YES
user_id=13823

I experienced the same problem and wrote a small patch to
solve the problem. It seems to work without problems :)

--- xmms-shell-0.99.3/src/window.cc 2002-10-23 02:05:19
+0200
+++ xmms-shell-new/src/window.cc 2003-12-22 18:01:51
+0100
@@ -58,7 +58,7 @@
status |= apply;
break;
case 2:
- status ^= ~(status & ~apply)
| apply;
+ status ^= apply;
break;
}