#6 segmentation fault for -e status

[Anonymous]

There seems to be a bit of a problem with the latest
release of xmms-shell.
I've got the latest versions of just about everything i
think is needed but xmms-shell is giving a segmentation
fault immediately after it has obtained and printed the
balance value when the command "xmms-shell -e status"
is given.

Richard Tresidder
rtresidd@tresar-electronics.com.au

[Nobody/Anonymous]

Logged In: NO

I can confirm this also.

Versions of my software are as follows

XMMS-Shell v0.99.3 by Logan Hanks <logan@vt.edu>
Build info: 11:50:47 Mar 3 2003 with 3.2.2 (Mandrake Linux
9.1 3.2.2-2mdk)
XMMS: 09A3

status command output is as follows...

[3419/4689] Sting Mercury Falling Sting_Mercury
Falling_05_You Still Touch Me.mp3 (playing)> status
Playing: Sting Mercury Falling Sting_Mercury Falling_05_You
Still Touch Me.mp3 (160 kbps, 44100 hz, 2 channels)
Time: 02:40.15
Repeat mode: off
Shuffle mode: off
Balance: 0
Aborted

(then back to the command prompt)

Let me know if you need any more information.

Regards,

Darren
sharman at technologist dot com

[Joel Martin]

Logged In: YES
user_id=9256

I know why this is happening and I have a patch.

In session.cc at line 222, the call to xmms_remote_get_skin
can return a NULL string. This used to work in 0.99.0
because the value
was directly printed. In 0.99.3 there is some C++
stringsification going
on and it apparently doesn't like the NULL string value.

I fixed it be returning an empty string instead of a NULL
string in
Session::skin()

Here is a patch file in case you like that kind of thing:
------------SNIP-----------------------------------------------
diff -ur xmms-shell-0.99.3.original/src/session.cc
xmms-shell-0.99.3/src/session.cc
--- xmms-shell-0.99.3.original/src/session.cc 2002-10-22
19:45:55.000000000 -0400
+++ xmms-shell-0.99.3/src/session.cc 2004-01-25
20:46:38.000000000 -0500
@@ -219,7 +219,11 @@
{
ensure_running();

- return xmms_remote_get_skin(sid);
+ if (xmms_remote_get_skin(sid)) {
+ return xmms_remote_get_skin(sid);
+ } else {
+ return "";
+ }
}

#if HAVE_XMMS_REMOTE_GET_EQ
------------SNIP-----------------------------------------------

[Davy Durham]

Logged In: YES
user_id=28588
Originator: NO

second (found and fixed).. nice in next release