Re: cvs

[Mike808 <mi...@ne...>]

Bron Gondwana wrote:
> > I really like Bron's idea about moving these `underbar' functions to a
> > seperate auxilliary sub-package.  That gives a clean interface to the
> > XML::XSLT library and makes it clear(er) that those functions are not
> > part of our public API.

I'm moving the tag_compression thingy out altogether so it becomes
a simple 'use XML::XSLT::Tag_Compression;' in the main module. The
docs go with it and we can have lexical file-scoped variables.

> Splitting the code into sections and separate files is good.  As is an
> internal API structure - for example I think all of value-of, apply-templates,
> etc should be in a single file which has a name something like
> XML::XSLT::BaseActions (maybe that's not the best name though)

Gee, this is starting to look more like the 'other XML::XSLT' ... :)

> > Shall we merge BRON1 into the developement branch?
> 
> Possibly.  Remember that there's some seriously broken changes that I made in
> places not realy understanding what I'd done - and I haven't had time to check
> it over again.  Specifically, I'm quite sure I broke variables.

> > I'll get rid of URI::Heuristic and LWP::Simple in my code
What do you need them for? I'm thinking you were looking for a way
to sniff a filename to see if it is a reachable URL? If so, I've
some some extensive work on that implementing URI-fetching from
porting the Java. It's builtin to Java, but not Perl. :(
And Java has this nifty InvalidURLException, so I had to fake one
with LWP. It's not pretty, but it does work.

I'll see what I can do when I take a look at what Bron's done.

> > Mark.  (Also sending to -devel, but it looks like neither you nor Bron
> > are on the list.)

Am now.

Heavily modifying the maint release, and I'll have to merge in the
typo fix that came in after. The indentation should be consistent,
the style should look more organized, and the documentation tweaked.

Mike.