Re: cvs

[Bron G. <br...@ne...>]

On Tue, Jul 18, 2000 at 04:20:00AM -0500, Mark A. Hershberger wrote:
> >>>>> "M" == Mike808  <mi...@ne...> writes:
> 
>     M> On an unrelated front, we've got double-underbar methods and
>     M> underbar methods and I'm not sure of Geert's intent via naming
>     M> conventions. Perhaps he can help with a short note and we can
>     M> document it. That way, we can remain consistent.
> 
> I really like Bron's idea about moving these `underbar' functions to a
> seperate auxilliary sub-package.  That gives a clean interface to the
> XML::XSLT library and makes it clear(er) that those functions are not
> part of our public API.

Splitting the code into sections and separate files is good.  As is an
internal API structure - for example I think all of value-of, apply-templates,
etc should be in a single file which has a name something like 
XML::XSLT::BaseActions (maybe that's not the best name though)

> Shall we merge BRON1 into the developement branch?

Possibly.  Remember that there's some seriously broken changes that I made in
places not realy understanding what I'd done - and I haven't had time to check
it over again.  Specifically, I'm quite sure I broke variables.

>     M> If we're not too worried, why the compelling need to switch
>     M> from hashes to arrays?
> 
> Lack of self-control ;->  ?
> 
> I was implementing the newer API that I had talked about and that
> other people seemed to want.  I started playing around with the
> arraryref implementation and it stuck.
> 
> You are right that the hashref is more "mergable", though.

Hashref is more maintainable, which is a good thing.  It's also more
back-compatible.

>     M> Well, I can focus on _add_node and _evaluate_element for
>     M> starters.  BEGIN's a pig, but it's a one-time deal, so I'm not
>     M> that worried.
> 
> I'll get rid of URI::Heuristic and LWP::Simple in my code -- things
> that slow it down substantially.  I'll also go back to the hashref
> implementation (which is really just a search and replace away) and
> work on making it more "mergable" with your work on the maint branch.
> 

They may be worth eval()ing in iff needed.  Something like:

if ($filename =~ m!^http://! or $filename =~ m!^ftp://!) {
    eval q{
        require LWP::Simple;
        LWP::Simple::import();
        require URI::Heuristic;
        URI::Heuristic::import();
    };
}

> Finally, I thought that I had committed your work on the -maint
> branch, but it appears that I haven't.  Could you re-commit it?
> 
> Mark.  (Also sending to -devel, but it looks like neither you nor Bron
> are on the list.)

Oops, I knew there was something I missed.  I've signed up per...@br...
to both of them now, and I'll remove whatever the other address was once I
get duplicate messages.

-- 
Bron ( back at work :)