xmlunit-general

[Xmlunit-general] XPath/Namespace API changed

[Stefan B. <bo...@ap...>]

Hi all,

after looking through James' patch for XML Schema validation I
realized that he was doing a few things differently from my namespace
patch for XPath.  Namely he was adding a property to the XMLUnit class
while I overloaded tons of assertion methods in both XMLAssert and
XMLTestCase.  James' approach is far more in line with the XMLUnit 1.0
codebase than mine.

I can't say that I like all the statics in XMLUnit too much but I
figured that a consistent API (or "conceptual integrity" if you want
to call it that) is more important than my personal preferences here.

Accordingly I've removed all the overloads and introduced a static
xpathNamespaceContext property (with getters and setters) to XMLUnit.

Stefan

-- 
http://stefan.samaflost.de/

Re: [Xmlunit-general] XPath/Namespace API changed

[James A. <jam...@gm...>]

On 16/01/07, Stefan Bodewig <bo...@ap...> wrote:
> Hi all,
>
> after looking through James' patch for XML Schema validation I
> realized that he was doing a few things differently from my namespace
> patch for XPath.  Namely he was adding a property to the XMLUnit class
> while I overloaded tons of assertion methods in both XMLAssert and
> XMLTestCase.  James' approach is far more in line with the XMLUnit 1.0
> codebase than mine.
>
> I can't say that I like all the statics in XMLUnit too much but I
> figured that a consistent API (or "conceptual integrity" if you want
> to call it that) is more important than my personal preferences here.

+1 about all the statics. My patch also demonstrated that if you do
set a static like this, you may need remember to use the tearDown()
method in your TestCase to unset / clear it afterwards. That's caught
me out a few times.

>
> Accordingly I've removed all the overloads and introduced a static
> xpathNamespaceContext property (with getters and setters) to XMLUnit.
>
> Stefan
>
> --
> http://stefan.samaflost.de/
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Xmlunit-general mailing list
> Xml...@li...
> https://lists.sourceforge.net/lists/listinfo/xmlunit-general
>

Re: [Xmlunit-general] XPath/Namespace API changed

[Stefan B. <bo...@ap...>]

On Wed, 17 Jan 2007, James Abley <jam...@gm...> wrote:
> On 16/01/07, Stefan Bodewig <bo...@ap...> wrote:

>> I can't say that I like all the statics in XMLUnit too much [...]
> 
> +1 about all the statics. My patch also demonstrated that if you do
> set a static like this, you may need remember to use the tearDown()
> method in your TestCase to unset / clear it afterwards. That's
> caught me out a few times.

Too true.  Still they are here to stay, at least for XMLUnit 1.1.

The blurry picture of XMLUnit 2.0 in my mind doesn't rely on them,
though ;-)

Stefan