xmlunit-commits

SF.net SVN: xmlunit:[511] trunk/xmlunit/src/main/java-legacy/org/ custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java

[<bo...@us...>]

Revision: 511
          http://xmlunit.svn.sourceforge.net/xmlunit/?rev=511&view=rev
Author:   bodewig
Date:     2013-02-03 11:06:30 +0000 (Sun, 03 Feb 2013)
Log Message:
-----------
merge fix for issue 3593368

Modified Paths:
--------------
    trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java

Property Changed:
----------------
    trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java

Modified: trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java
===================================================================
--- trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java	2013-02-03 10:48:45 UTC (rev 510)
+++ trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java	2013-02-03 11:06:30 UTC (rev 511)
@@ -1,6 +1,6 @@
 /*
 ******************************************************************
-Copyright (c) 2008, Jeff Martin, Tim Bacon
+Copyright (c) 2008,2013 Jeff Martin, Tim Bacon
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without
@@ -60,7 +60,7 @@
             try {
                 double controlVal = Double.parseDouble(control);
                 double testVal = Double.parseDouble(test);
-                return Math.abs(controlVal - testVal) < tolerance
+                return Math.abs(controlVal - testVal) <= tolerance
                     ? DifferenceListener.RETURN_IGNORE_DIFFERENCE_NODES_IDENTICAL
                     : DifferenceListener.RETURN_ACCEPT_DIFFERENCE;
             } catch (NumberFormatException nfe) {


Property changes on: trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java
___________________________________________________________________
Added: svn:mergeinfo
   + /branches/xmlunit-1.x/src/java/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java:346,353,494,510

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

SF.net SVN: xmlunit:[543] trunk/xmlunit/src/main/java-legacy/org/ custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java

[<bo...@us...>]

Revision: 543
          http://sourceforge.net/p/xmlunit/code/543
Author:   bodewig
Date:     2013-09-12 15:11:18 +0000 (Thu, 12 Sep 2013)
Log Message:
-----------
using an absolute tolerance value might not be a good idea

Modified Paths:
--------------
    trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java

Modified: trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java
===================================================================
--- trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java	2013-09-12 15:10:05 UTC (rev 542)
+++ trunk/xmlunit/src/main/java-legacy/org/custommonkey/xmlunit/examples/FloatingPointTolerantDifferenceListener.java	2013-09-12 15:11:18 UTC (rev 543)
@@ -41,6 +41,10 @@
 /**
  * Expects texts to be floating point numbers and treats them as
  * identical if they only differ by a given tolerance value (or less).
+ *
+ * <p>This implementation uses an absolute tolerance value value for
+ * all numbers encountered, calculating a difference relative to one
+ * of the numbers compared might be more appropriate in general.</p>
  */
 public class FloatingPointTolerantDifferenceListener
     extends TextDifferenceListenerBase {

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.