[Xmlunit-general] Comparison.getControlDetails().getTarget()

[Harald B. <bra...@gm...>]

Hi,

I made the changes: 
https://github.com/brabenetz/xmlunit/commit/3f824ef2b7cb348efea76b85d3d5a35da7fe8550

If the DOMDifferenceEngine is the one and only implementation, then I think embrace DOM as part of XMLUnit's diff API is fine,

But if there is another implementation then DOMDifferenceEngine planned, then it's maybe (depends on the other implementations) better to reject the changes. 

with friendly regards,

Harald


> Gesendet: Sonntag, 15. Februar 2015 um 19:51 Uhr
> Von: "Stefan Bodewig" <bo...@ap...>
> An: "Harald Brabenetz" <bra...@gm...>
> Cc: xml...@li...
> Betreff: Re: [Xmlunit-general] ComparisonControllers.StopWhenSimilar
>
> ...
>
> > But one Question:
> > Why is the return type of "Comparison.getControlDetails().getTarget()" an Object?
> > Is there any case where the return Object is not a org.w3c.dom.Node?
> 
> This is likely part of the somewhat ambiguos API in the diff package.
> Parts of it try to abstract from DOM, other parts are tied to it.  If we
> agreed to embrace DOM as part of XMLUnit's diff API, then we may as well
> switch to Node here.
> 
> Stefan
>