|
From: Stefan B. <bo...@ap...> - 2015-02-21 21:30:05
|
On 2015-02-21, Joe Hayes wrote: > On Sat, Feb 21, 2015 at 11:35 AM, Stefan Bodewig <bo...@ap...> wrote: >> Note pack currently doesn't work on Linux, even after changing exec to >> invoke mono explicitly: >> [exec] Attempting to build package from 'xmlunit.nuspec'. >> [exec] File not found: 'build\net\bin\xmlunit-core.dll'. >> the file is there, using forward slashes, of course. I guess it is the >> file element in the nuspec file but didn't dare to change it to forward >> slashes. Looking through the nuget issue tracker "pack" seems to have >> other problems as well, so I'll have to resort to a Windows VM. > I'll get a linux VM with mono up and running so I can be aware of these > issues before I send a pull request! :-) Thanks. It is not the most important thing, since said "Windows VM" actually exists. >> As for the nuspec content, I'm not sure about the authors and owners >> elements, it seems authors is required. I'm sure I'd forget to update >> that line after accepting PRs. Can we use "XMLUnit contributors" as >> authors or is this frowned upon? > I'm not sure but I'm happy to change it. I'd prefer to not put names in there. It may be just me and maybe others who have contributed feel differently. >>> Some additional build/NuGet related TODOs (which I'm happy to work on): >>> - create an additional nuspec for the constraints assembly >>> - create a symbols package ( >> https://docs.nuget.org/create/creating-and-publishing-a-symbol-package) >> does this include publishing the sources? > It can but I do not believed it is required. Do you have a preference? Include them, please. >>> - adopt semantic version-ing for .NET build >> We are already publishing XMLUnit for Java SNAPSHOT builds (whenever I >> feel like it, not automatically). For nuget packages something like >> 2.0.0-alpha-01 would likely be a good initial version. > Sounds good. >>> - .NET framework targeting >> are we missing anything? > We should explicitly set the target framework in the NAnt build script (by > default, it uses the framework on which it is running) and change the > nuspec file accordingly. I see. I've tried to keep it at .NET 3.5 compatibility right now, basically requiring LINQ. > I can add these issues to the XmlUnit.NET GitHub issue tracker unless you > have another preference. Sounds good. Stefan |