From: Stefan B. <bo...@ap...> - 2015-02-19 11:54:18
|
On 2015-02-18, Will Herrmann wrote: > I finally got a chance to make this change. I created a pull request for > GitHub. Many thanks. > I'm still new to open source stuff, so let me know if I missed > something about the procedure. All is fine. Harald's original ComparisonFormatter proposal had a static final ComparisonFormatter field (DEFAULT, I think) which contained a DefaultComparisonFormatter - ah, yes - https://github.com/xmlunit/xmlunit/commit/e457399addf2db7d399e2d06d07064d3bee5ca03#diff-417caeda82b46db9f1bafca5765b3ff4R26 I later removed it because I thought only Diff would need it. With your change maybe it is time to bring it back and use it from Difference and Comparison as well? Stefan |