Re: [Xmlunit-general] ComparisonControllers.StopWhenSimilar

[Stefan B. <bo...@ap...>]

Hi Harald

On 2015-02-07, Harald Brabenetz wrote:

> For the CompareMatcher I need also a
> ComparisonControllers.StopWhenSimilar implementation:
> https://github.com/brabenetz/xmlunit/commit/8bbda11263c1385ee97876235c4f1de63babe05e
> Let me know what you think. I will then create a separate pull
> request.

Sounds reasonable.

> I think the Hamcrest CompareMatcher should always stop the comparison
> depending on "checkForIdentical()" or "checkForSimilar()".  I think a
> public method like ".withComparisonController()" is only confusing for
> the Hamcrest CompareMatcher.

Yes, this is probably correct.  For the matcher the
isIdentical/SimilarTo methods cover the use cases of what you'd do with
a custom ComparisonController otherwise.

Stefan