Re: [Xmlunit-general] ComparisonController

[Harald B. <bra...@gm...>]

Hi,

I cleaned up the changes for DiffBuilder and ComparisonFormatter:
https://github.com/brabenetz/xmlunit/commit/04c195c62388b59023a6af28df1e54b106886f9c

And applied the changes for the ComparisonController:
https://github.com/brabenetz/xmlunit/commit/3028db8eae60bc85dabd5e9bbe632f89ae08afc9

Is there something open?
I will then squash the changes to one pull request and start with the Matcher.

with friendly regards,
Harald


> Gesendet: Samstag, 24. Januar 2015 um 19:46 Uhr
> Von: "Stefan Bodewig" <bo...@ap...>
> An: "Harald Brabenetz" <bra...@gm...>
> Cc: xml...@li...
> Betreff: Re: [Xmlunit-general] ComparisonController
>
> On 2015-01-24, Harald Brabenetz wrote:
> 
> >> I've moved the shared test resources to a separate repository. This
> >> means you need to run "git submodule update --init" once inside your
> >> working copies after merging github's master branches of xmlunit or
> >> xmlunit.net.
> 
> > Thanks, something new for me.
> > A little bit like "svn:externals" in svn.
> 
> Well, it is not as simple as svn:externals, but I guess the way we use
> it in XMLUnit is very similar to externals.
> 
> >> I've created a branch in order to experiment with separating the "do we
> >> want to stop comparing" functionality from "how severe is this
> >> difference".
> >> https://github.com/xmlunit/xmlunit/compare/ComparisonController
> 
> > looks really great! I can't wait to update the DiffBuilder.
> 
> Thanks, I merged the branch.
> 
> I'll port it over to .NET and the next bigger step will be experimenting
> with a clean implementation for DOMDifferenceEngine, one that doesn't
> look as ad hoc.
> 
> Stefan
>