[Xmlunit-general] ComparisonController

[Stefan B. <bo...@ap...>]

Hi

I've created a branch in order to experiment with separating the "do we
want to stop comparing" functionality from "how severe is this
difference".

https://github.com/xmlunit/xmlunit/compare/ComparisonController

The implementation in DifferenceEngine using Map.Entry is just a quick
hack, I didn't want to distract from the API change by refactoring
DifferenceEngine.

To me it feels cleaner to have them separate, it removed some clumsy
workarounds in DOMDifferenceEngineTest where a custom
DifferenceEvaluator delegated to DefaultStopWhenDifferent - of course at
the expense of other workarounds (the wrap methods).

The code in legacy's NewDifferenceEngine looks cleaner as well.

Stefan