Menu
▾
▴
[Xmltv-devel] [ xmltv-Bugs-3163183 ] _na_dtv: does not return data
|
From: SourceForge.net <no...@so...> - 2012-01-05 03:07:56
|
Bugs item #3163183, was opened at 2011-01-20 23:21 Message generated for change (Comment added) made by alewando You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3163183&group_id=39046 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: tv_grab_na_dtv Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Rod Roark (sunsetsystems) Summary: _na_dtv: does not return data Initial Comment: Looks like the grabber is now broken since 12/04 (http://www.crustynet.org.uk/~xmltv-tester/squeeze/nightly/) Tried to run it manually with --debug, but not much information about the issue: $> tv_grab_na_dtv --debug Getting IDs for day 0 ............ Getting IDs for day 1 ............ Getting IDs for day 2 ............ Getting IDs for day 3 ............ Getting IDs for day 4 ............ Getting one more ... <?xml version="1.0" encoding="ISO-8859-1"?> <!DOCTYPE tv SYSTEM "xmltv.dtd"> <tv source-info-url="http://www.directv.com/" source-info-name="DirecTV" generator-info-name="XMLTV" generator-info-url="http://www.xmltv.org/"> </tv> $>tv_grab_na_dtv --list-channels --debug <?xml version="1.0" encoding="ISO-8859-1"?> <!DOCTYPE tv SYSTEM "xmltv.dtd"> <tv source-info-url="http://www.directv.com/" source-info-name="DirecTV" generator-info-name="XMLTV" generator-info-url="http://www.xmltv.org/"> </tv> ---------------------------------------------------------------------- >Comment By: Adam Lewandowski (alewando) Date: 2012-01-04 19:07 Message: dekart, That's how I am filtering, but without adjusting the UTC times returned by DirecTV to the local time, you can't tell if a show straddles the days. For example, 'The Tonight Show' starts at 11:35 EST and lasts 1 hour. So it's returned by DirecTV as '2012-01-04T04:35:00+0000' and ends at '2012-01-04T05:35:00+0000'. If you're after listings for 2012-01-04, you couldn't tell that this show straddles two days unless you adjust to local time. Am I missing something? ---------------------------------------------------------------------- Comment By: Karl Dietz (dekarl) Date: 2012-01-03 00:41 Message: I can look at the other grabbers for an example later this week, but some filter out overlap with very simple filters. (basically filtering so that each program is only returned for the day it starts on, but not for the day it overflows into or the other way around) So you should not need the local time (well, unless you value the feature of returning explicit local time in itself.) ---------------------------------------------------------------------- Comment By: Adam Lewandowski (alewando) Date: 2012-01-02 18:39 Message: dekarl, I'll look into dropping the DateTime::Format::XMLTV requirement. I didn't realize it was that new, it just seemed easier than any other alternative. I had to add timezone support to get the grabber to pass validation. I needed it to eliminate overlap. When you ask for listings for a specific day, DirecTV returns shows that start the previous day but have their end time on the requested day. Since all the times are returned in UTC, I needed to convert them to local time to detect when this has happened and remove those listings. I tried getting DateTime to determine the local UTC offset, but couldn't get it working. I'll take another crack at it later this week. ---------------------------------------------------------------------- Comment By: Karl Dietz (dekarl) Date: 2012-01-02 15:23 Message: alewando, when I looked at the change I noticed that you require DateTime::Format::ISO8601 and DateTime::Format::XMLTV, too. At least the latter is quite new and likely not packaged on all distributions so it might be a good idea to not require them if you want the grabber to easily run on older installations as it avoids new dependencies. Also you require the users to specify which local time zone they want. You can replace that with just writing out explicit UTC as it was or you can make DateTime use whatever time is configured in the system as local time. Basically leading to correct local time without an additional configuration option. btw, you can validate your grabber with "./grab/test_grabbers --only na_dtv" rmeden, if you like I can connect the new grabber to the build so we see how the tester likes it. ---------------------------------------------------------------------- Comment By: Adam Lewandowski (alewando) Date: 2012-01-01 20:20 Message: Just commited the updated grabber. I made some more changes since originally posting, replacing Date::Manip modules DateTime and adding timezone support. Should pass validation now. Let me know if there are any problems. ---------------------------------------------------------------------- Comment By: Rod Roark (sunsetsystems) Date: 2011-12-30 08:30 Message: Hey... code changes look reasonable offhand... I don't have the means to easily test it any more so will just say if it works, by all means proceed. Thanks! ---------------------------------------------------------------------- Comment By: Robert Eden (rmeden) Date: 2011-12-30 07:43 Message: alewando, I've added you as a DEV... if the maintainer (Rod?) doesn't respond in a few days please commit your update to cvs. ---------------------------------------------------------------------- Comment By: Adam Lewandowski (alewando) Date: 2011-12-29 19:37 Message: Updated DirecTV grabber (tv_grab_na_dtv) posted at https://github.com/alewando/xmltv ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=424135&aid=3163183&group_id=39046 |