#391 tv_grab_za errors

none
closed
tv_grab_za (5)
5
2014-04-14
2009-12-23
kl1k kl1k
No

when running the latest nightly build I get the follow error:

Initialising cookies
getting listings
cannot look up 'Crime & Investigation' in map at /usr/bin/tv_grab_za line 395.

This occurs on various channels. The problem is due to DSTV calling the channels different names.

Editing tv_grab_za and inserting the below and recompiling solves the problem:

my %dstvchannelfixups = (
'CNN International' => 'CNN',
'SABC 1' => 'SABC1',
'SABC 2' => 'SABC2',
'SABC 3' => 'SABC3',
'MagicWorld' => 'Magic World',
'Crime & Investigation Network' => 'Crime & Investigation',
'E! Entertainment Television' => 'E',
'Deutsche Welle' => 'Deutchse Welle',
'SuperSport MaXimo 1' => 'SuperSport Maximo',
'SONY' => 'Sony Entertainment');

With the above error can the code be changed so that it skips the incorrectly named instead if dying with a error? (eg Soweto TV is in the channel list but not on the DSTV site so the application dies when it tries to pull data for that channel. I know I could comment it out but it would be better if the error was handled.

Discussion

  • Francois Botha

    Francois Botha - 2009-12-24

    Thanks. I've fixed tv_grab_za a few months ago but was too lazy to commit the changes. Apart from your suggestions there are some other fixes too. I'm on holiday at the moment but will commit in once i'm back. Promise↲↲You're the only other Saffa i know of that uses it so I'd like to work with you in testing future enhancements. I'll contact you directly.↲↲Regards,↲Francois

     
  • kl1k kl1k

    kl1k kl1k - 2009-12-26

    Great - thanks for the feedback.

    Feel free to contact me - I'd love to be a tester.

     
  • Francois Botha

    Francois Botha - 2010-03-10

    kl1k, have you been able to test the fixes?

     
  • Nick Morrott

    Nick Morrott - 2010-04-12

    It might be an idea to add these mappings to a file that can be loaded at run-time via XMLTV::Supplement. This way, a new release of the grabber does not have to be made when channel names change.

     
  • kl1k kl1k

    kl1k kl1k - 2010-04-18

    Good idea knowledgejunkie. As now the Hallmark channel has also been renamed as well as a few others.

     
  • Francois Botha

    Francois Botha - 2010-04-19

    Thanks, knowledgejunkie. I'll try to implement this as soon as possible.

     
  • Nick Morrott

    Nick Morrott - 2010-04-24
    • assigned_to: nobody --> igitur
     
  • Karl Dietz

    Karl Dietz - 2010-11-15

    Is this fix still important after application of the last two patches? I'd prefer to remove the fixups completely as the MNET fallback got disabled anyway, so there's no reason to convert back and forth between channel ids and channel names...

     
  • Geoff

    Geoff - 2014-04-14

    This table is deprecated (i.e. no longer needed) in version 1.44

     
  • Geoff

    Geoff - 2014-04-14
    • status: open --> closed
    • Group: --> none
     

Log in to post a comment.