Menu ▾ ▴

ver0.7 - mistakes & possible error

Help
Anonymous
2003-09-30
2003-09-30

  • Anonymous

    Anonymous - 2003-09-30

    I use XmlRpc++ 0.7 on Win2k and C++ Builder 5.0

    1. I noticed one mistake in XmlRpcSocket.cpp. You should define two more directives:

       # define EINTR WSAEINTR
       # define EAGAIN WSATRY_AGAIN

    in "#if defined(_WINDOWS)" section. There are compiler errors without it.

    2.
    XmlRpcClient.cpp 398: Possibly incorrect assignment in function XmlRpcClient::parseResponse(XmlRpcValue &):

      // Expect either <params><param>... or <fault>...
      if ((XmlRpcUtil::nextTagIs(PARAMS_TAG,_response,&offset) &&
           XmlRpcUtil::nextTagIs(PARAM_TAG,_response,&offset)) ||
          XmlRpcUtil::nextTagIs(FAULT_TAG,_response,&offset) && (_isFault = true))

    I suppose you should change last condition to:
              ..(_isFault == true))

     

    • Anonymous

      Anonymous - 2003-09-30

      ... (_isFault = true)
      it's just hidden assigment
      so it's not very clear code ;)

       

Log in to post a comment.