Re: [xmlroff] errors during fo:external-graphic processing

[Tony G. <Ton...@Su...>]

Stefan Seefeld <se...@sy...> writes:
> Tony Graham wrote:
>> Committed (with modifications), thank you.
>
> Great, thanks !

Thank you both for pushing for implementing the capability and for doing the
hardest part of the work with your patch.

> I don't know the xsl-fo specs very well, but does the 'src' attribute in
> external-graphic allow any uri type, in particular, any scheme ? In that cases,
> you should probably use libxml2's nanohttp module to load the file content,
> instead of assuming it is a local file.

Yes, it could be a HTTP URI.

I did start looking at nanohttp yesterday (and you'd also have to consider
nanoftp), but I'm not considering holding up the release until they are
added.  We can work on those for the next release.

> Also, I note you have stripped off the content-type attribute with the
> libfo-compat.xsl. What content-types does xmlroff support right now, and

As you pointed out, xmlroff can't parse content-type values.

> how does it detect them ? By file extension ? (I note you are using
> 'gdk_pixbuf_new_from_file' but documentation for that only indicates
> 'The file format is detected automatically.' I think supported formats
> have to be well-documented.

You know as much as I do about supported file formats, since all I know is
that line from the GDK documentation.

I had forgotten that 'content-type' is an extended conformance requirement,
whereas we're still targetting basic conformance, so while 'content-type'
support would be nice to have, it is not yet essential.

I have added comments to the conformance information to indicate that xmlroff
only does local files and the image formats supported by the underlying image
library.

We can add tests to the testsuite to show what common file formats are
supported and what aren't.

Regards,


Tony.