Re: [xmlroff] 'border-color' property

[Tony G. <Ton...@Su...>]

Julian Rosse <gn...@th...> writes:
>   I wrote the code for #3 (adding border-style and border-width resolution
> support to fo_context_util_border_resolve()).  However, it won't even be
> able to compile until other stuff is plugged in, so I guess I should wait
> on sending a patch.

Okay.

>> >   I guess just let me know what you'd like me to work on.
>> 
>> #1, I guess.
>
> I added the two <property> tags to dump-info.xml (I copied the attributes
> from looking at the border-color <property> compared to the individual
> border-*-color <property>s), ran make, and looked at
> diffs between some of the output files and the ones in xmlroff/ currently.
> What's the best way to add the relevant new stuff for border-style and
> border-width to the appropriate files?  I figured since I'd be submitting
> it as a patch anyway, maybe the easiest thing would be to run cvs diff on
> the files and then manually edit the patch to only include the lines
> relevant to those two properties.

The easiest way would be to submit the patch for
spec-dump/dump-info.xml and a separate patch for xmlroff/fo-context.c
and xmlroff/fo-context{-private}?.h.

Since the properties' files are new, I'll just merge your
dump-info.xml patch, make the properties' files, and copy them over.

>   I'm also not entirely sure about which
> files need to be updated and which ones need manual editing of what
> spec-dump dumps.  For example, the spec-dump README talks about updating
> fo/fo-* formatting object files when you add a property that those fo's
> may have, but it didn't look like anything in the xmlroff/fo/ cvs had
> border-color added.  Is that because it's a shorthand or something?

Yes.  The FO's don't have properties for the shorthands because the
shorthands are resolved to individual properties.

>   It looks to me like these are some of the things I have to do regarding
> the spec-dumped files:
>
>   manually modify property/fo-property-border-{style,width}.c in similar ways
> to how property/fo-property-border-color.c is different from the file that
> spec-dump dumps and add these and their corresponding header files.

Some of those differences are because I changed my mind on things
after I generated the original fo-property-border-color.[ch] files.

I have modified 'dump-info.xml' to reduce the differences.

I also added support for a 'expr-eval' attribute on <property>
elements in dump-info.xml so there'll be one less piece of manual
fixup on the generated files.

>   add the dumped sections of fo-context.[ch] and fo-context-private.h which
> are relevant to the two properties.

Yes.

When you look at the diffs, you'll see evidence of my indecision about
what to do about components of spaces and traces of a few properties
that haven't been implemented yet.  As you say, add the "relevant"
portions to the files.

>   run "make fo-all-property-h-dump" and add the lines relevant to the two
> properties.

Yes.

> Is that it?

They need to be added to property/Makefile.am, otherwise they'll never
get compiled.

Thanks again.

Regards,


Tony.