From: Julian R. <gn...@th...> - 2005-03-06 16:34:56
|
Hi, I wrote the code for #3 (adding border-style and border-width resolution support to fo_context_util_border_resolve()). However, it won't even be able to compile until other stuff is plugged in, so I guess I should wait on sending a patch. > > I guess just let me know what you'd like me to work on. > > #1, I guess. I added the two <property> tags to dump-info.xml (I copied the attributes from looking at the border-color <property> compared to the individual border-*-color <property>s), ran make, and looked at diffs between some of the output files and the ones in xmlroff/ currently. What's the best way to add the relevant new stuff for border-style and border-width to the appropriate files? I figured since I'd be submitting it as a patch anyway, maybe the easiest thing would be to run cvs diff on the files and then manually edit the patch to only include the lines relevant to those two properties. I'm also not entirely sure about which files need to be updated and which ones need manual editing of what spec-dump dumps. For example, the spec-dump README talks about updating fo/fo-* formatting object files when you add a property that those fo's may have, but it didn't look like anything in the xmlroff/fo/ cvs had border-color added. Is that because it's a shorthand or something? It looks to me like these are some of the things I have to do regarding the spec-dumped files: manually modify property/fo-property-border-{style,width}.c in similar ways to how property/fo-property-border-color.c is different from the file that spec-dump dumps and add these and their corresponding header files. add the dumped sections of fo-context.[ch] and fo-context-private.h which are relevant to the two properties. run "make fo-all-property-h-dump" and add the lines relevant to the two properties. Is that it? Thanks, Julian |