From: <gn...@th...> - 2005-03-05 20:04:47
|
Hi, > Thanks, Julian. I've checked in your patch. It should be generally > available from anonymous CVS shortly. Cool, thanks. > Are you ready for 'border-width' and 'border-style'? Sure. I've been looking at a lot of the relevant code. Judging by our discussions and looking at the ChangeLog entries for adding border-color, it looks like some of the tasks are: 1. Add border-style and border-width <property>s to spec-dump and add/merge the relevant dumped files 2. Add parallel functions to fo_expr_border_color_eval() and eval_border_color_expr() to expr/fo-expr-eval.[ch] for border-style and border-width 3. Add similar code to the border-color patch I submitted to fo_context_util_border_resolve() for border-style and border-width 4. Add lines for border-width and border-style to property/fo-property-eval.c (? - spec-dump doesn't generate this, right?) Correct (I'm just checking here)? Are there other tasks? I can definitely do #3 if it is just duplicating the logic that I added for border-color. I'm not sure I know the mechanics of #1 exactly - running spec-dump and adding/merging stuff. I looked at expr/fo-expr-eval.c; I might be able to help with #2, but that would be more challenging, especially the lexing/parsing code, I'd think. #4 looks trivial. I guess just let me know what you'd like me to work on. On another note, how do I get the cvs xmlroff/ sources into a configure-able/make-able state? I just did "autoconf configure.in" and it yelled at me for some undefined macros. I can give you details if this is news. I'm not familiar with the autotools etc. Thanks, Julian |