From: Tony G. <Ton...@Su...> - 2005-02-28 12:50:47
|
The code now in CVS implements mapping the X11 colour names to FoColor objects. I also added fo_color_new_with_value() so that colours are immutable once created, and I put a hash table (actually, a FoHashTable) in FoColorClass so there's only ever one instance of a particular colour. Along the way, I added FoHashTable as an object-aware hash table type and added fo_object_equal() and fo_object_hash() so every FoObject so every FoObject type can define its own equality and hash functions. I also discovered that fo_color_get_color_fuschia() has been returning purple for I don't know how long. If anyone has time to write a test case, we need a test case or two to test the X11 colour support (although not every colour unless you're really enthusiastic). I would suggest a property/color/color2.fo to keep it separate from the spec-defined colours in property/color/color1.fo. Given my recent experience with fuschia, I would also suggest that the test case include both the colour specified by name and the colour specified by value to make sure the right colour is being found when specified by name. Can someone create such a test case? Regards, Tony. |