Re: [XMLPipeDB-developer] UniProtDatabaseProfile submits
Brought to you by:
kdahlquist,
zugzugglug
From: Richard B. <rbr...@gm...> - 2011-09-02 18:05:00
|
OK, so still two outstanding issues regarding the last 2 modified methods: 1. getInfoTableManager() Still returning 3 species names when only two are selected. Returns one species name when only one is selected. - I will review the loop again and see if I can determine what is going on here. 2. getSystemTableManager() I added a for loop within the while condition which after discussions we know is incorrect. Will pull that out but we need to determine how to move forward with the issue of determining which species each id belongs to. removed loop and submitted to SourceForge but now build is essentially broken till we figure out the wrinkle. Adding a for speciesprofile loop at the top was discussed as a solution of last resort. UniProtDatabaseProfile - while loop begins at line # 585 --------------------------------------------------------------------------------------------------------------- Also made modifications to getSystemsTableManager() which applies the species customizations for each species profile selected. Seems correct to me but please confirm. -------------------------------------------------------------------------------------------------------------- Discussions surrounding getPrimarySystemTableManager() assumed likely bad coding since it seems to call for a customized schema although it is identical to the default UniProt schema. It calls getPrimarySystemTableManagerCustomizations() which is specific to Arabidopsis thaliana and Ecoli only. Didn't want to dig into this yet until other higher priority modifications were done first plus I believe a discussion with Dr. D was going to occur as well. --------------------------------------------------------------------------------------------------------------- getRelationsTableManager() is the last method which remains untouched but I will start reviewing and come up with a plan of attack. -------------------------------------------------------------------------------------------------------------- These are all the loose ends I can think of to document. Thanks! Richard On Wed, Aug 31, 2011 at 12:52 PM, Richard Brous <rbr...@gm...> wrote: > Submitted changes to UniProtDatabaseProfile based on the logical > corrections from yesterdays convo with Dondi. > > These do not yet include the discussed optimizations, just wanted to get it > working and do some test exports... which completed successfully. > > I also added a for loop under the while loop in getSystemTableManager() to > ensure each query result is processed for each selected species profile. > The loop is on line 587 and I added it because it seemed a solution to have > each species profile included... is this correct or should I be submitting > all at once versus each species? > > Richard > |