Menu
▾
▴
xml-cppdom-devel
|
From: Patrick H. <pat...@gm...> - 2011-10-09 14:38:07
|
Due to my regrettably limited time for, well, virtually everything, I hadn't noticed that Ryan Pavlik made a CMake build for CppDOM. I was just looking it over, and while it appears to have a lot of things not needed for building CppDOM, it seems to me that it would be a good addition to CppDOM. I am not sufficiently skilled at reading CMake code to tell if it supports everything that the SCons build does, but to be blunt, I am pretty sick of SCons. Even if the CMake build isn't quite ready to replace the SCons build, I would be glad to see CMake available for building CppDOM. Would it be worthwhile to merge Ryan's CMake build into the CppDOM SVN trunk? If so, I can do the initial merge and checkin. Would anyone have time to add information to the README file explaining how to use this build, possibly promoting it as the preferred alternative to the SCons build? -Patrick -- Patrick L. Hartling Senior Software Engineer, Priority 5 http://www.priority5.com/ |
|
From: Doug M. <mc...@ia...> - 2012-05-26 02:27:25
|
Patrick, This seems like a useful thing to merge. There are some recent changes to scons that appear to be wrecking havoc with some of our scons builds so we are also looking at migrating away from scons. If it is merged I can test it and provide patches for things that fail. Doug On Oct 9, 2011, at 9:37 AM, Patrick Hartling wrote: > Due to my regrettably limited time for, well, virtually everything, I hadn't noticed that Ryan Pavlik made a CMake build for CppDOM. I was just looking it over, and while it appears to have a lot of things not needed for building CppDOM, it seems to me that it would be a good addition to CppDOM. I am not sufficiently skilled at reading CMake code to tell if it supports everything that the SCons build does, but to be blunt, I am pretty sick of SCons. Even if the CMake build isn't quite ready to replace the SCons build, I would be glad to see CMake available for building CppDOM. Would it be worthwhile to merge Ryan's CMake build into the CppDOM SVN trunk? If so, I can do the initial merge and checkin. Would anyone have time to add information to the README file explaining how to use this build, possibly promoting it as the preferred alternative to the SCons build? > > -Patrick > |
|
From: Patrick H. <pat...@gm...> - 2012-07-04 20:34:38
Attachments:
smime.p7s
|
I copied the CMake build into the trunk and the 1.2 branch. If it needs to be added to the 1.0 branch, I can do that quite easily. -Patrick On May 25, 2012, at 9:27 PM, Doug McCorkle wrote: > Patrick, > > This seems like a useful thing to merge. There are some recent changes to scons that appear to be wrecking havoc with some of our scons builds so we are also looking at migrating away from scons. If it is merged I can test it and provide patches for things that fail. > > Doug > > On Oct 9, 2011, at 9:37 AM, Patrick Hartling wrote: > >> Due to my regrettably limited time for, well, virtually everything, I hadn't noticed that Ryan Pavlik made a CMake build for CppDOM. I was just looking it over, and while it appears to have a lot of things not needed for building CppDOM, it seems to me that it would be a good addition to CppDOM. I am not sufficiently skilled at reading CMake code to tell if it supports everything that the SCons build does, but to be blunt, I am pretty sick of SCons. Even if the CMake build isn't quite ready to replace the SCons build, I would be glad to see CMake available for building CppDOM. Would it be worthwhile to merge Ryan's CMake build into the CppDOM SVN trunk? If so, I can do the initial merge and checkin. Would anyone have time to add information to the README file explaining how to use this build, possibly promoting it as the preferred alternative to the SCons build? >> >> -Patrick >> > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Xml-cppdom-devel mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel -- Patrick L. Hartling iOS Library Developer, T8 Webware http://www.t8webware.com/ |
|
From: Doug M. <mc...@ia...> - 2012-07-06 19:00:59
|
I tested this out and the build appears OK. It seems that the cppdom-config script is missing from the install target. I am not sure how important this is. I can add it if it is needed. Also, it seems there is a bunch of CMake "cruft" in the cmake directory. Is this needed? Doug On Jul 4, 2012, at 3:34 PM, Patrick Hartling wrote: > I copied the CMake build into the trunk and the 1.2 branch. If it needs to be added to the 1.0 branch, I can do that quite easily. > > -Patrick > > On May 25, 2012, at 9:27 PM, Doug McCorkle wrote: > >> Patrick, >> >> This seems like a useful thing to merge. There are some recent changes to scons that appear to be wrecking havoc with some of our scons builds so we are also looking at migrating away from scons. If it is merged I can test it and provide patches for things that fail. >> >> Doug >> >> On Oct 9, 2011, at 9:37 AM, Patrick Hartling wrote: >> >>> Due to my regrettably limited time for, well, virtually everything, I hadn't noticed that Ryan Pavlik made a CMake build for CppDOM. I was just looking it over, and while it appears to have a lot of things not needed for building CppDOM, it seems to me that it would be a good addition to CppDOM. I am not sufficiently skilled at reading CMake code to tell if it supports everything that the SCons build does, but to be blunt, I am pretty sick of SCons. Even if the CMake build isn't quite ready to replace the SCons build, I would be glad to see CMake available for building CppDOM. Would it be worthwhile to merge Ryan's CMake build into the CppDOM SVN trunk? If so, I can do the initial merge and checkin. Would anyone have time to add information to the README file explaining how to use this build, possibly promoting it as the preferred alternative to the SCons build? >>> >>> -Patrick |
|
From: Patrick H. <pat...@gm...> - 2012-07-06 20:36:00
Attachments:
smime.p7s
|
cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. What qualifies as CMake cruft? I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. -Patrick On Jul 6, 2012, at 2:00 PM, Doug McCorkle wrote: > I tested this out and the build appears OK. It seems that the cppdom-config script is missing from the install target. I am not sure how important this is. I can add it if it is needed. Also, it seems there is a bunch of CMake "cruft" in the cmake directory. Is this needed? > > Doug > > On Jul 4, 2012, at 3:34 PM, Patrick Hartling wrote: > >> I copied the CMake build into the trunk and the 1.2 branch. If it needs to be added to the 1.0 branch, I can do that quite easily. >> >> -Patrick >> >> On May 25, 2012, at 9:27 PM, Doug McCorkle wrote: >> >>> Patrick, >>> >>> This seems like a useful thing to merge. There are some recent changes to scons that appear to be wrecking havoc with some of our scons builds so we are also looking at migrating away from scons. If it is merged I can test it and provide patches for things that fail. >>> >>> Doug >>> >>> On Oct 9, 2011, at 9:37 AM, Patrick Hartling wrote: >>> >>>> Due to my regrettably limited time for, well, virtually everything, I hadn't noticed that Ryan Pavlik made a CMake build for CppDOM. I was just looking it over, and while it appears to have a lot of things not needed for building CppDOM, it seems to me that it would be a good addition to CppDOM. I am not sufficiently skilled at reading CMake code to tell if it supports everything that the SCons build does, but to be blunt, I am pretty sick of SCons. Even if the CMake build isn't quite ready to replace the SCons build, I would be glad to see CMake available for building CppDOM. Would it be worthwhile to merge Ryan's CMake build into the CppDOM SVN trunk? If so, I can do the initial merge and checkin. Would anyone have time to add information to the README file explaining how to use this build, possibly promoting it as the preferred alternative to the SCons build? >>>> >>>> -Patrick > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Xml-cppdom-devel mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel -- Patrick L. Hartling iOS Library Developer, T8 Webware http://www.t8webware.com/ |
|
From: Doug M. <mc...@ia...> - 2012-07-06 20:50:31
|
On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: > cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. OK, I can get it in. > > What qualifies as CMake cruft? All of the find scripts and compiler check files that are not needed/used for the cppdom build. > I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. Doug |
|
From: Doug M. <mc...@ia...> - 2012-07-27 19:52:26
|
On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: > > On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: > >> cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. > > OK, I can get it in. > >> >> What qualifies as CMake cruft? > All of the find scripts and compiler check files that are not needed/used for the cppdom build. > >> I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. > You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. Here is the first patch to cleanup the CMake scripts. I will work on adding a couple other things to the CMake build to make version tracking a bit easier and to ease using cppdom in third party projects. www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch Doug |
|
From: Patrick H. <pat...@gm...> - 2012-07-27 22:31:29
Attachments:
smime.p7s
|
On Jul 27, 2012, at 2:52 PM, Doug McCorkle <mc...@ia...> wrote: > On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: > >> >> On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: >> >>> cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. >> >> OK, I can get it in. >> >>> >>> What qualifies as CMake cruft? >> All of the find scripts and compiler check files that are not needed/used for the cppdom build. >> >>> I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. >> You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. > > Here is the first patch to cleanup the CMake scripts. I will work on adding a couple other things to the CMake build to make version tracking a bit easier and to ease using cppdom in third party projects. > > www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch I applied your patch to the trunk and to the 1.2 branch. Thanks for taking the time to prepare that. -Patrick -- Patrick L. Hartling iOS Library Developer, Banno http://www.banno.com/ |
|
From: Doug M. <mc...@ia...> - 2012-07-28 01:19:39
|
On Jul 27, 2012, at 5:31 PM, Patrick Hartling wrote: > On Jul 27, 2012, at 2:52 PM, Doug McCorkle <mc...@ia...> wrote: > >> On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: >> >>> >>> On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: >>> >>>> cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. >>> >>> OK, I can get it in. >>> >>>> >>>> What qualifies as CMake cruft? >>> All of the find scripts and compiler check files that are not needed/used for the cppdom build. >>> >>>> I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. >>> You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. >> >> Here is the first patch to cleanup the CMake scripts. I will work on adding a couple other things to the CMake build to make version tracking a bit easier and to ease using cppdom in third party projects. >> >> www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch > > > I applied your patch to the trunk and to the 1.2 branch. Thanks for taking the time to prepare that. Thanks Patrick. It appears that the deletion of the sub directories in the cmake directory did not make it into the patch for some reason. Could you delete all of the sub directories that are currently in the cmake directory? Thanks. Doug |
|
From: Doug M. <mc...@ia...> - 2012-07-28 01:49:36
Attachments:
AddVersionAndConfig.patch
|
On Jul 27, 2012, at 5:31 PM, Patrick Hartling wrote: > On Jul 27, 2012, at 2:52 PM, Doug McCorkle <mc...@ia...> wrote: > >> On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: >> >>> >>> On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: >>> >>>> cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. >>> >>> OK, I can get it in. >>> >>>> >>>> What qualifies as CMake cruft? >>> All of the find scripts and compiler check files that are not needed/used for the cppdom build. >>> >>>> I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. >>> You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. >> >> Here is the first patch to cleanup the CMake scripts. I will work on adding a couple other things to the CMake build to make version tracking a bit easier and to ease using cppdom in third party projects. >> >> www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch > > > I applied your patch to the trunk and to the 1.2 branch. Thanks for taking the time to prepare that. This patch: 1. Adds the cppdom-config back to the install target 2. Corrects the usage of lib and lib64 install directories based on the build type 3. Builds a version.h file based on the version info in the CMake scripts (this officially breaks the SCons build) 4. Only installs the SpiritParser.h file if it is compiled into the library Doug |
|
From: Doug M. <mc...@ia...> - 2012-07-30 15:18:24
Attachments:
FinderFilesAndVersionedLibs.patch
|
On Jul 27, 2012, at 8:49 PM, Doug McCorkle wrote: > > On Jul 27, 2012, at 5:31 PM, Patrick Hartling wrote: > >> On Jul 27, 2012, at 2:52 PM, Doug McCorkle <mc...@ia...> wrote: >> >>> On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: >>> >>>> >>>> On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: >>>> >>>>> cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. >>>> >>>> OK, I can get it in. >>>> >>>>> >>>>> What qualifies as CMake cruft? >>>> All of the find scripts and compiler check files that are not needed/used for the cppdom build. >>>> >>>>> I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. >>>> You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. >>> >>> Here is the first patch to cleanup the CMake scripts. I will work on adding a couple other things to the CMake build to make version tracking a bit easier and to ease using cppdom in third party projects. >>> >>> www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch >> >> >> I applied your patch to the trunk and to the 1.2 branch. Thanks for taking the time to prepare that. > > This patch: > 1. Adds the cppdom-config back to the install target > 2. Corrects the usage of lib and lib64 install directories based on the build type > 3. Builds a version.h file based on the version info in the CMake scripts (this officially breaks the SCons build) > 4. Only installs the SpiritParser.h file if it is compiled into the library Here is a patch to follow on to rev 703. This patch: 1. Removes hard tabs from the CMake files 2. Adds helper files to the CMake build to make it easier to find in other CMake projects 3. Adds versioned library files back to the build 4. Places the flagpoll file in the lib directory rather than the share directory From my testing that puts the build back to where SCons was. In my opinion the SCons files could be deleted at this point. Doug |
|
From: Ryan P. <rp...@ia...> - 2012-07-31 18:06:28
|
Is there any particular reason that the minimum required cmake version was changed here in line 6: https://github.com/vancegroup/cppdom/blame/master/CMakeLists.txt I certainly haven't added anything that needs 2.8.8 - it should work with 2.8.0 and probably even with the original value listed there (2.6.2?) In any case, having that value higher than necessary breaks more builds than necessary. Ryan On Mon, Jul 30, 2012 at 10:18 AM, Doug McCorkle <mc...@ia...> wrote: > > On Jul 27, 2012, at 8:49 PM, Doug McCorkle wrote: > > > > > On Jul 27, 2012, at 5:31 PM, Patrick Hartling wrote: > > > >> On Jul 27, 2012, at 2:52 PM, Doug McCorkle <mc...@ia...> wrote: > >> > >>> On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: > >>> > >>>> > >>>> On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: > >>>> > >>>>> cppdom-config is a legacy script that wraps flagpoll usage. I don't > know how important it is at this point, but installing it would maintain > consistency with the SCons build. > >>>> > >>>> OK, I can get it in. > >>>> > >>>>> > >>>>> What qualifies as CMake cruft? > >>>> All of the find scripts and compiler check files that are not > needed/used for the cppdom build. > >>>> > >>>>> I just grabbed everything from the Git repository. I don't think > that I committed anything extra by mistake, but I don't have a good eye for > what is critical for CMake to do its job. > >>>> You did grab everything correctly. I checked with Ryan and he is > alright with getting that directory cleaned up. I will go through and > create a patch for it. > >>> > >>> Here is the first patch to cleanup the CMake scripts. I will work on > adding a couple other things to the CMake build to make version tracking a > bit easier and to ease using cppdom in third party projects. > >>> > >>> www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch > >> > >> > >> I applied your patch to the trunk and to the 1.2 branch. Thanks for > taking the time to prepare that. > > > > This patch: > > 1. Adds the cppdom-config back to the install target > > 2. Corrects the usage of lib and lib64 install directories based on the > build type > > 3. Builds a version.h file based on the version info in the CMake > scripts (this officially breaks the SCons build) > > 4. Only installs the SpiritParser.h file if it is compiled into the > library > > Here is a patch to follow on to rev 703. This patch: > > 1. Removes hard tabs from the CMake files > 2. Adds helper files to the CMake build to make it easier to find in other > CMake projects > 3. Adds versioned library files back to the build > 4. Places the flagpoll file in the lib directory rather than the share > directory > > From my testing that puts the build back to where SCons was. In my opinion > the SCons files could be deleted at this point. > > Doug > > > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Xml-cppdom-devel mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel > > -- Ryan Pavlik HCI Graduate Student Virtual Reality Applications Center Iowa State University rp...@ia... http://academic.cleardefinition.com |
|
From: Doug M. <mc...@ia...> - 2012-07-31 18:17:46
|
I am using new function macros that became available in 2.8.8. Doug On Jul 31, 2012, at 12:37 PM, Ryan Pavlik wrote: > Is there any particular reason that the minimum required cmake version was changed here in line 6: > https://github.com/vancegroup/cppdom/blame/master/CMakeLists.txt > > I certainly haven't added anything that needs 2.8.8 - it should work with 2.8.0 and probably even with the original value listed there (2.6.2?) In any case, having that value higher than necessary breaks more builds than necessary. > > Ryan > > On Mon, Jul 30, 2012 at 10:18 AM, Doug McCorkle <mc...@ia...> wrote: > > On Jul 27, 2012, at 8:49 PM, Doug McCorkle wrote: > > > > > On Jul 27, 2012, at 5:31 PM, Patrick Hartling wrote: > > > >> On Jul 27, 2012, at 2:52 PM, Doug McCorkle <mc...@ia...> wrote: > >> > >>> On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: > >>> > >>>> > >>>> On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: > >>>> > >>>>> cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. > >>>> > >>>> OK, I can get it in. > >>>> > >>>>> > >>>>> What qualifies as CMake cruft? > >>>> All of the find scripts and compiler check files that are not needed/used for the cppdom build. > >>>> > >>>>> I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. > >>>> You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. > >>> > >>> Here is the first patch to cleanup the CMake scripts. I will work on adding a couple other things to the CMake build to make version tracking a bit easier and to ease using cppdom in third party projects. > >>> > >>> www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch > >> > >> > >> I applied your patch to the trunk and to the 1.2 branch. Thanks for taking the time to prepare that. > > > > This patch: > > 1. Adds the cppdom-config back to the install target > > 2. Corrects the usage of lib and lib64 install directories based on the build type > > 3. Builds a version.h file based on the version info in the CMake scripts (this officially breaks the SCons build) > > 4. Only installs the SpiritParser.h file if it is compiled into the library > > Here is a patch to follow on to rev 703. This patch: > > 1. Removes hard tabs from the CMake files > 2. Adds helper files to the CMake build to make it easier to find in other CMake projects > 3. Adds versioned library files back to the build > 4. Places the flagpoll file in the lib directory rather than the share directory > > >From my testing that puts the build back to where SCons was. In my opinion the SCons files could be deleted at this point. > > Doug > > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Xml-cppdom-devel mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel > > > > > -- > Ryan Pavlik > HCI Graduate Student > Virtual Reality Applications Center > Iowa State University > > rp...@ia... > http://academic.cleardefinition.com > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________ > Xml-cppdom-devel mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel |
|
From: Doug M. <mc...@ia...> - 2012-08-03 14:23:02
Attachments:
clang.patch
|
Here is hopefully the last patch. This corrects the flagpoll creation when using the clang compiler. Doug On Tue, Jul 31, 2012 at 1:17 PM, Doug McCorkle <mc...@ia...> wrote: > I am using new function macros that became available in 2.8.8. > > Doug > > On Jul 31, 2012, at 12:37 PM, Ryan Pavlik wrote: > >> Is there any particular reason that the minimum required cmake version was changed here in line 6: >> https://github.com/vancegroup/cppdom/blame/master/CMakeLists.txt >> >> I certainly haven't added anything that needs 2.8.8 - it should work with 2.8.0 and probably even with the original value listed there (2.6.2?) In any case, having that value higher than necessary breaks more builds than necessary. >> >> Ryan >> >> On Mon, Jul 30, 2012 at 10:18 AM, Doug McCorkle <mc...@ia...> wrote: >> >> On Jul 27, 2012, at 8:49 PM, Doug McCorkle wrote: >> >> > >> > On Jul 27, 2012, at 5:31 PM, Patrick Hartling wrote: >> > >> >> On Jul 27, 2012, at 2:52 PM, Doug McCorkle <mc...@ia...> wrote: >> >> >> >>> On Jul 6, 2012, at 3:50 PM, Doug McCorkle wrote: >> >>> >> >>>> >> >>>> On Jul 6, 2012, at 3:35 PM, Patrick Hartling wrote: >> >>>> >> >>>>> cppdom-config is a legacy script that wraps flagpoll usage. I don't know how important it is at this point, but installing it would maintain consistency with the SCons build. >> >>>> >> >>>> OK, I can get it in. >> >>>> >> >>>>> >> >>>>> What qualifies as CMake cruft? >> >>>> All of the find scripts and compiler check files that are not needed/used for the cppdom build. >> >>>> >> >>>>> I just grabbed everything from the Git repository. I don't think that I committed anything extra by mistake, but I don't have a good eye for what is critical for CMake to do its job. >> >>>> You did grab everything correctly. I checked with Ryan and he is alright with getting that directory cleaned up. I will go through and create a patch for it. >> >>> >> >>> Here is the first patch to cleanup the CMake scripts. I will work on adding a couple other things to the CMake build to make version tracking a bit easier and to ease using cppdom in third party projects. >> >>> >> >>> www.vrac.iastate.edu/~mccdo/CMakeCleanup.patch >> >> >> >> >> >> I applied your patch to the trunk and to the 1.2 branch. Thanks for taking the time to prepare that. >> > >> > This patch: >> > 1. Adds the cppdom-config back to the install target >> > 2. Corrects the usage of lib and lib64 install directories based on the build type >> > 3. Builds a version.h file based on the version info in the CMake scripts (this officially breaks the SCons build) >> > 4. Only installs the SpiritParser.h file if it is compiled into the library >> >> Here is a patch to follow on to rev 703. This patch: >> >> 1. Removes hard tabs from the CMake files >> 2. Adds helper files to the CMake build to make it easier to find in other CMake projects >> 3. Adds versioned library files back to the build >> 4. Places the flagpoll file in the lib directory rather than the share directory >> >> >From my testing that puts the build back to where SCons was. In my opinion the SCons files could be deleted at this point. >> >> Doug >> >> >> >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Xml-cppdom-devel mailing list >> Xml...@li... >> https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel >> >> >> >> >> -- >> Ryan Pavlik >> HCI Graduate Student >> Virtual Reality Applications Center >> Iowa State University >> >> rp...@ia... >> http://academic.cleardefinition.com >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________ >> Xml-cppdom-devel mailing list >> Xml...@li... >> https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Xml-cppdom-devel mailing list > Xml...@li... > https://lists.sourceforge.net/lists/listinfo/xml-cppdom-devel |
|
From: Doug M. <mc...@ia...> - 2012-08-06 02:23:15
Attachments:
CMakeLists.txt.patch
|
Here is a patch that corrects where the flagpoll and cmake build files are places on windows in the install target. Doug |
|
From: Doug M. <mc...@ia...> - 2012-08-28 13:22:22
Attachments:
CMakeLists.txt.patch
|
Yet another patch to resolve cmake issues.... This one resolves the construction of the fpc file on windows. Doug |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X