[xml-cppdom-devel] Re: [xml-cppdom-checkins] cvs commit: cppdom/cppdom cppdom.h

[Patrick H. <pa...@13...>]

This change is invalid and breaks the build with GCC and MIPSpro.  The 
return type for Attribute::getValue<T>() is based on the template 
parameter, and 'const std::string&' does not match 'std::string'.

  -Patrick

Kevin Meinert wrote:
> subatomic    2003/02/22 15:07:54 PST
> 
>   Modified files:
>     cppdom               cppdom.h 
>   Log:
>   use
>   
>      const std::string& getValue<std::string>() const
>   
>   instead of
>   
>      std::string getValue<std::string>() const
>   
>   since were returning mData, this would be faster (just a pointer instead
>   of a temporary.)
>   
>   slightly related, this also fixes a crash bug in one of my applications,
>   somehow it was dying in the destructor of std::string if I called
>   getValue<std::string>....  strange. :(   all good now though.
>   
>   Revision  Changes    Path
>   1.67      +4 -4      cppdom/cppdom/cppdom.h
> 
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/xml-cppdom/cppdom/cppdom/cppdom.h.diff?r1=1.66&r2=1.67&diff_format=h
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
> The most comprehensive and flexible code editor you can use.
> Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
> www.slickedit.com/sourceforge
> _______________________________________________
> Xml-cppdom-checkins mailing list
> Xml...@li...
> https://lists.sourceforge.net/lists/listinfo/xml-cppdom-checkins


-- 
Patrick L. Hartling			| Research Assistant, VRAC
pa...@13...				| 2274 Howe Hall Room 2624
PGP: http://www.137.org/patrick/pgp.txt	| T: +1.515.294.4916
http://www.137.org/patrick/		| http://www.vrac.iastate.edu/