Re: [xml-cppdom-devel] Patch for Win32 dllexport goop

[Ben S. <bs...@ia...>]

That would be a good change. Please apply the patch.

-Ben

Patrick Hartling wrote:

> Does anyone have any objections to the attached patch?  The 
> preprocessor would be unhappy if both CPPDOM_EXPORTS and 
> CPPDOM_IMPORTS were defined, and I don't think it should be necessary 
> for user code to define CPPDOM_IMPORTS.
>
>  -Patrick
>
>
>------------------------------------------------------------------------
>
>Index: config.h
>===================================================================
>RCS file: /cvsroot/xml-cppdom/cppdom/cppdom/config.h,v
>retrieving revision 1.9
>diff -u -r1.9 config.h
>--- config.h	14 Jan 2003 22:29:55 -0000	1.9
>+++ config.h	16 Jan 2003 15:25:30 -0000
>@@ -63,9 +63,7 @@
> // export/import #define's for building a win32 dll
> # ifdef CPPDOM_EXPORTS
> #  define CPPDOM_API __declspec(dllexport)
>-# endif
>-
>-# ifdef CPPDOM_IMPORTS
>+# else
> #  define CPPDOM_API __declspec(dllimport)
> # endif
> 
>  
>