[Xmi2code-develop] Re: xmi2code

[Leandro L. <lu...@ll...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

AJ Harrington, el domingo  7 de septiembre a las 13:00 me escribiste:
> Hello,
> 
> First off, I would just like to say thank you!  xmi2code is a fantastic 
> utility.  Being an umbrello user, I found it very, very helpful (especially 
> the round trip engineering!).

I'm glad to know you find it usefull, even when muy contribution is so
small :)

> Now (and I'm sure I've overstepped myself with this), I would like to submit a 
> set of changes.  It started out that I simply wanted to be able to use a 
> dependency and to indicate (and add in the code) a friend class.  However,
> I kind of went berserk and did quite a bit.

Nice! 8-)

> Here's a list of my implemented changes:
> 
> 1)  Changed the single Association class to a hierarchy based on a 
> Relationship class (sorry, I was reading "The Unified Modeling Language 
> User's Guide" by Booch,Rumbaugh,Jacobson at the time).  The full hierarchy 
> wasn't implemented, just the classes to handle inheritance (Generalization) 
> and dependencies (Dependency).

This was on muy TODO list, It's great you started the work. I'm just
learning C++ and it could be very hard for me... :)
I wanted to do it to add Interfaces supports to add a PHP5 Generator.

> 2)  Added (with the Dependency class) the coded documentation commands:
> x2c:friend (to add a friend class) and x2c:uses (to indicate a uses 
> dependency).

I don't understand why two commands are needed for adding a friend
class... There's no special "widget" in umbrello to add a dependency?

> 3)  Refactored Umbrello::codedDocumentation from one single member function to 
> multiple overloaded member functions (one for each pointer type).

Sounds well.

> 4)  Added (I'm sure re-added) mNoClass back to Class to prevent compile time 
> errors in the *generator.cpp files (all seem to call related Class:: member 
> functions)

Errors? When I compile it I just get one warning for the Ada Generator.

> 5) Added member functions Model::getDependancies and Model::addDependancy to 
> handle Dependency relationships.
> 6) Added printForwardDeclarations and printFriends to CppGenerator.
> 7) Project wide modifications to change Association to Generalization.

Sounds well.

> It's been a while since I've used diff correctly, so I've included a patch 
> file (and copies of my added files) AND a complete tar ball of everything 
> based on a cvs checkout from early this week.

Ok, since I'm not (yet :) a regular C++ developer, I can't test very
much the pathes. Even more, I'm glad C++ generator isn't broken with my
changes :)
Following Rolands steps (who give me an account when I wanted to contribute
the code) I can give you write access to the CVS so you can commit the
changes yourself, just give me your sf user if you want.

> I've got a couple of questions on some things, that I was wondering why you 
> implemented them in the way you did...I just want to understand your design 
> mentality.
> 
> 1)  Why don't you print any includes in the implementation files?
> 2)  Why does x2c:inc:filename.h want to create a file?

I can't answer this, I've just made the PHP PEAR generator and some
minor changes... :)

> Even if you hate everything, if you could drop me a line and tell me what 
> sucks and why, I'd really appreciate it.

I didn't take a look to the code yet (I'm working on a college proyect
right now) but the changes sounds great!!!

> Once again thank you for the great software!

PS: I Cc-ed this mail to the developers mailing list:
http://lists.sourceforge.net/lists/listinfo/xmi2code-develop
You are invited! :)

- -- 
LUCA - Leandro Lucarella - Usando Debian GNU/Linux Sid - GNU Generation
- ------------------------------------------------------------------------
E-Mail / JID:     lu...@lu...
GPG Fingerprint:  D9E1 4545 0F4B 7928 E82C  375D 4B02 0FE0 B08B 4FB2 
GPG Key:          gpg --keyserver pks.lugli.org.ar --recv-keys B08B4FB2
- ------------------------------------------------------------------------
Every morning is a Smirnoff morning.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/W6MKSwIP4LCLT7IRAqw9AJ9h4VqBjdSroi8QMKa+7OXfJ68VJACeKJxA
o9EzvBqo+zvQBmQvB0ZC7Kg=
=s9WY
-----END PGP SIGNATURE-----