Menu

#2 please sort object files to make build reproducible

1.1.11
closed
None
2016-04-25
2016-04-04
No

lib/Makefile uses wildcards when building libraries from object files.
This can cause libXmHTML.so.1.1 and libXmHTML.a to vary depending on the filesystem and collation settings where they were built.

Please consider the attached patch which sorts the order in which object files are linked.

Please see the following link for more information:
https://wiki.debian.org/ReproducibleBuilds

There may be additional Makefiles where wildcards are used, I only checked those used to build the XmHTML package in Debian.

1 Attachments

Discussion

  • Dusan Peterc

    Dusan Peterc - 2016-04-06

    Thank you Graham, will be fixed.

     
  • Christian Linhart

    Thank you Graham for your patch. I have merged it now.
    Do you need a new release with this patch or are there more patches expected in the near future?

     
  • Christian Linhart

    • status: open --> closed
    • assigned_to: Christian Linhart
    • Milestone: 1.0 --> 1.1.11
     
  • Graham Inggs

    Graham Inggs - 2016-04-25

    Thanks for the merge! I don't need a new release just for this, Debian can carry the patch until your next release.

     

Log in to post a comment.