[xmds-devel] Issue in DSFMTGenerator.tmpl

[Noah <noa...@pr...>]

Hi XMDS developers,

I've come across an issue in the file `DSFMTGenerator.tmpl`, in the method template `[generate_float_close1_open2_via_dsfmt](https://sourceforge.net/p/xmds/code/HEAD/tree/trunk/xpdeint/xpdeint/Stochastic/Generators/DSFMTGenerator.tmpl#l107)`, where the method creates two random numbers and stores one for the next time it is called. When the method is called twice and passed two different generators, it will return a random number generated with the first input both times.

Some possible fixes include generating the method for every noise vector (would have to do the same for `generate_float_array_close0_open1` as well), checking if the input has changed, or simply removing the optimisation.

Also, Joe informed me that the issue of `[generate_float_array_close0_open1](https://sourceforge.net/p/xmds/code/HEAD/tree/trunk/xpdeint/xpdeint/Stochastic/Generators/DSFMTGenerator.tmpl#l140)` (in the same file) not using its parameters has been addressed, but it doesn't seem to have been pushed yet.

Thanks for the help,
Noah