#57 Incorrect suffix for libraries

[Luke]

Hi,

When compiling xlslib (version 2.4.0) the libraries are created with 2.0.3 suffix instead of 2.4.0. This is on Red Hat Linux 5.2 with standard gcc 4.1.2.

Output from configure:

Configuration summary
=====================

xlslib (version 2.4.0) is now configured as follows:

* Compilation environment

  CC           = gcc -std=gnu99
  CFLAGS       =  -g -O2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers
  CPP          = gcc -std=gnu99 -E
  CPPFLAGS     =
  CXX          = g++
  CXXFLAGS     =  -g -O2 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers
  LD           = /usr/bin/ld -m elf_x86_64
  LDFLAGS      =
  LIBS         =
  INSTALLFLAGS =
  BINDIR       =

* xlslib options

  Development-time debugging:               no
  Allow profiling using gprof:              no
  Allow profiling using prof:               no
  Allow test coverage analysis using gcov:  no
  Build:                                    release (default optimizations)

  Settings:

-----------------------------------------------------------------------

Congratulations, your xlslib 2.4.0 is configured now.

Created libraries:

drwxrwx--- 2     1165 Oct 27 12:56 ./
lrwxrwx--- 1       12 Oct 27 12:56 libxls.la -> ../libxls.la*
-rwxrwx--- 1      911 Oct 27 12:56 libxls.lai*
drwxrwxr-x 7     2282 Oct 27 12:56 ../
-rwxrwx--- 1  7651486 Oct 27 12:56 libxls.a*
lrwxrwx--- 1       15 Oct 27 12:56 libxls.so -> libxls.so.2.0.3*
lrwxrwx--- 1       15 Oct 27 12:56 libxls.so.2 -> libxls.so.2.0.3*
-rwxrwx--- 1  3212434 Oct 27 12:56 libxls.so.2.0.3*

[David Hoerl]

I just searched all files and cannot find a 2.0.3 string anywhere. Then I just poked around and found this in Makefile.in:

libxls_la_LDFLAGS = $(XLSLIB_LIBS) -version-info 2:3:0

I'm going to guess that's where its coming from. Now, if you read the notes on that flag:

https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

Its not suppose to be the release number. That said, it probably should be updated. We are not changing the API to break backwards compatibility ever to this library, so not sure it really needs to be changed. Suggestions?

[Luke]

Hi,

I'm not suggesting that the version should match the library version but according to the guideline on the link provided at least one number could be increased every time there is any source code change.
For me it was very confusing because I was convinced I somehow built the old version and had to triple check. Also it would allow installing multiple versions in to the same folder.

Best regards,
Luke

[David Hoerl]

Its now 3:0:0 in 2.5.0, just posted.