Menu

#8 Questionable Constructor implementation in AbstractExchange

2.13
open
nobody
core (9)
5
2011-04-29
2011-04-29
Adarsh
No

I am raising this as a bug. In the below implementation in the AbstractExchange,
The constructor parameter "workerpool" is never used in this particular invocation. Then what is the point in passing the same. Since, you are setting the "executor" instance variable from somewhere else.

protected AbstractExchange(AbstractExchange parentExchange, Executor workerpool) {
this.parentExchange = parentExchange;
executor = HttpUtils.newMultimodeExecutor();
}

There is no sufficient comments also to understand this miscellaneous kind of implementation.

Discussion


Log in to post a comment.

MongoDB Logo MongoDB