#109 Code generation does not avoid Java keywords

1.3.0 (final)
open
nobody
2
2005-11-21
2005-03-29
No

When trying to build the WAR file for an API that has
an entity named 'case' I found that the code generation
does not handle Java keywords properly:

build/java-fundament/art/nl/wanadoo/art/api/GetTestDetails.java:215:
<identifier> expected
public void addCase(GetTestDetails.Case case) {
^
/home/ernst/wanadoo-apis/build/java-fundament/art/nl/wanadoo/art/api/GetTestDetails.java:263:
')' expected
^
build/java-fundament/art/nl/wanadoo/art/api/GetTestList.java:178:
<identifier> expected
public void addCase(GetTestList.Case case) {
^
build/java-fundament/art/nl/wanadoo/art/api/GetTestList.java:247:
')' expected
build/java-fundament/art/nl/wanadoo/art/api/GetTestList.java:334:
<identifier> expected
public void addCase(Case case) {
^
build/java-fundament/art/nl/wanadoo/art/api/GetTestList.java:337:
')' expected
^
build/java-fundament/art/nl/wanadoo/art/api/GetTestRunDetails.java:305:
<identifier> expected
public void addCase(GetTestRunDetails.Case case) {
^
build/java-fundament/art/nl/wanadoo/art/api/GetTestRunDetails.java:538:
')' expected

The code generation code should detect Java keywords
and avoid them.

Discussion

  • Ernst de Haan

    Ernst de Haan - 2005-04-15

    Logged In: YES
    user_id=11053

    Anthony: We should decide whether we tackle this problem
    before 1.2.0 (final) or that we postpone it to afterwards.

    If we intend to tackle it before, then we should add some
    testcases already, in which all Java keywords are used in:
    1) input parameters;
    2) output parameters
    3) input data section element names;
    4) output section element names;
    5) input data section attribute names;
    6) output data section attribute names.

    Do you consider fixing this bug feasible for 1.2.0 (final) ?

     
  • Ernst de Haan

    Ernst de Haan - 2005-04-15
    • assigned_to: nobody --> agoubard
     
  • Anthony Goubard

    Anthony Goubard - 2005-04-15

    Logged In: YES
    user_id=987589

    I would postpone it after 1.2.0 as it won't occur that often
    and if it occurs the compiler fails with some explanations.

     
  • Ernst de Haan

    Ernst de Haan - 2005-04-20
    • assigned_to: agoubard --> nobody
    • status: open --> pending
     
  • Ernst de Haan

    Ernst de Haan - 2005-04-20

    Logged In: YES
    user_id=11053

    After XINS 1.2.0.

     
  • Anthony Goubard

    Anthony Goubard - 2005-04-20
    • priority: 4 --> 1
     
  • Anthony Goubard

    Anthony Goubard - 2005-04-21
    • status: pending --> open
     
  • Ernst de Haan

    Ernst de Haan - 2005-08-12
    • milestone: 412778 --> 445536
     
  • Ernst de Haan

    Ernst de Haan - 2005-11-01
    • priority: 1 --> 2
     
  • Ernst de Haan

    Ernst de Haan - 2005-11-21
    • milestone: 445536 --> 1.3.0 (final)
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks