From: Kirill B. <kir...@gm...> - 2008-03-24 21:41:01
Attachments:
wav_playback_fix.diff
|
Hi! Current "wav" demuxer assumes that the first chunk will always have the tag "fmt ", which is not true - there are WAV files where the first chunk has tag "bext" for example. As the result, "wav" demuxer fails on opening such files. The attached patch fixes this: instead of assuming that the "fmt " chunk is the first one, demuxer will now traverse the list of chunks searching for the "fmt ". This traversal is similar to the one that happens when searching for "data" chunk, so I have also moved the traversal code into the separate function. The sample that is not playable with the current xine-lib from Mercurial can be found in attachments to this bugzilla issue: http://bugzilla.gnome.org/show_bug.cgi?id=343837 Regards, Kirill |
From: Darren S. <li...@yo...> - 2008-03-24 23:46:06
|
I demand that Kirill Belokurov may or may not have written... > Current "wav" demuxer assumes that the first chunk will always have the tag > "fmt ", which is not true - there are WAV files where the first chunk has > tag "bext" for example. As the result, "wav" demuxer fails on opening such > files. > The attached patch fixes this: instead of assuming that the "fmt " chunk is > the first one, demuxer will now traverse the list of chunks searching for > the "fmt ". This traversal is similar to the one that happens when > searching for "data" chunk, so I have also moved the traversal code into > the separate function. [snip] Committed. I edited the commit message, though; it needed a summary line. -- | Darren Salt | linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | + Use more efficient products. Use less. BE MORE ENERGY EFFICIENT. Never give an inch! |