From: Michael Roitzsch <mroi@us...> - 2002-08-27 19:22:14
> I tried a recent xine CVS and again I got very high system times,
> just like the last time. (The infamous SMP stall problem.)
> I noticed that on the console, I got very frequent
> "video_out_dxr3: setting aspect ratio to anamorphic" messages.
> I looked at the code and I found that it always sets the
> aspect ratio with the ioctl() call. I quickly came up with this
> patch that keeps track the last set aspect ratio and doesn't set it
> again if it's already set to the same value. I had to do it in the
> xine code
> because the EM8300_IOCTL_GET_ASPECTRATIO ioctl does not
> work. This is defined in the em8300.h but not used in it's modules'
> This modification is only slightly tested. Maybe "this->aspect_ll =3D
> -1;" is needed some more places not just at init time.
This should not happen. Your patch is based on the right ideas, but the=20
dxr3 video out should already do the checking you suggest. I think you=20
have discovered a very silly typo in video_out_dxr3.c which I just=20
fixed in cvs. Could you try a fresh checkout again, please?
/* Fuck me gently with a chainsaw... */
From: Michael Roitzsch <mroi@us...> - 2002-08-29 12:33:11
On Thursday, 29. August 2002 13:21, Boszormenyi Zoltan wrote:
> >> This should not happen. Your patch is based on the right ideas,
> >> but the dxr3 video out should already do the checking you suggest.
> >> I think you have discovered a very silly typo in video_out_dxr3.c
> >> which I just fixed in cvs. Could you try a fresh checkout again,
> >> please?
> > I will test it.
> It worked.
Thanks for testing and thanks for presenting this silly bug. I would=20
never have found that since things worked fine here. Although I don't=20
understand _why_ it worked here. Puzzled.
Who the fuck is "General Failure", and why is he reading my disk?