[xine-devel] Re: [xine-user] SPU fixed in CVS

[Rich Wareham <rjw57@ca...>]

On Tuesday 13 February 2001  7:11 pm, Hetz Ben Hamo wrote:
> Fixed as in version 0.3.7 or the new 0.4 development version?

The new development version.

>
> Hetz
>
> On Tuesday 13 February 2001 13:47, Rich Wareham wrote:
> > As per subject line. Also added a brief section on subtitles in the
> > README.
> >
> > Rich

-- 
==================================================================
Rich Wareham <rjw57@...>
Robinson College, Cambridge, CB3 9AN

His followers called him Mahasamatman and said he was a god.  He preferred
to drop the Maha- and the -atman, however, and called himself Sam.  He never
claimed to be a god.  But then, he never claimed not to be a god.  Circum-
stances being what they were, neither admission could be of any benefit.
Silence, though, could.  It was in the days of the rains that their prayers
went up, not from the fingering of knotted prayer cords or the spinning of
prayer wheels, but from the great pray-machine in the monastery of Ratri,
goddess of the Night.  The high-frequency prayers were directed upward through
the atmosphere and out beyond it, passing into that golden cloud called the
Bridge of the Gods, which circles the entire world, is seen as a bronze
rainbow at night and is the place where the red sun becomes orange at midday.
Some of the monks doubted the orthodoxy of this prayer technique...
		-- Roger Zelazny, "Lord of Light"
==================================================================

Re: [xine-devel] 0.4.0alpha is in CVS

[Rich Wareham <rjw57@ca...>]

On Tuesday 13 February 2001  1:48 pm, you wrote:
> Hi Rich,
>
> On Mon, 12 Feb 2001, Rich Wareham wrote:
> > On Monday 12 February 2001  4:13 am, you wrote:
> > > - spu decoder: yes, it was me, I broke it - sorry folks!
> > >   I didn't want to wait any longer with my commit, so I checked it in
> > >   as it is.
> >
> > Well fixed it. Take a look below. Comments? If its OK with everyone, I'll
> > check it in tommorrow morning.
>
> looks very clean to me :-)
>
> erm, that
>
> > printf ("xine_init: video thread created\n");
>
> is a bit misleading, "spu thread created" would be better instead.

Yeah. I noticed that when I was merging. Fixed now.

>
> Apart from that I'm impressed how fast you adapted the SPU stuff to the
> new architecture (!)

np

[snip]

> The next step would be to make the subtitles work in xshm as well - this
> would require to move the subtitle decoding from display to decoding time
> so the subtitle overlay could be copied to the rgb buffer during the
> yuv2rgb conversion.

From the POV of video_out, it doesn't care when the decoding is done, jsut 
that the buffers overlay_image and mask_image contain the correct subtitle 
images in the correct format. As it is, the SPU decoder can only decode to 
YUV (although RGB shouldn't be /that/ hard). It would be better to overlay 
onto the image before conversion but when I tried that I couldn't find any 
way of detecting if the video decoder had finished with the image (i.e. bits 
of subtitle kept wandering around due to motion compensation :)). Does the 
new architecture help this?

-- 
==================================================================
Rich Wareham <rjw57@...>
Robinson College, Cambridge, CB3 9AN

Go to a movie tonight.  Darkness becomes you.
==================================================================

Re: [xine-devel] 0.4.0alpha is in CVS

[Guenter Bartsch <bartscgr@st...>]

Hi Rich,

On Mon, 12 Feb 2001, Rich Wareham wrote:

> On Monday 12 February 2001  4:13 am, you wrote:
> 
> > - spu decoder: yes, it was me, I broke it - sorry folks!
> >   I didn't want to wait any longer with my commit, so I checked it in
> >   as it is.
> 
> Well fixed it. Take a look below. Comments? If its OK with everyone, I'll 
> check it in tommorrow morning.

looks very clean to me :-)

erm, that

> printf ("xine_init: video thread created\n");

is a bit misleading, "spu thread created" would be better instead.

Apart from that I'm impressed how fast you adapted the SPU stuff to the
new architecture (!)

One thing we could investigate is the idea to do without a seperate
spu-thread and instead let the tick() function do the decoding as well -
avoiding the need to buffer the spu data. Whenever tick () is called it
could peek at the spu fifo if there's any data older than the current vpts
and decode that data thus having the right subtitles for overlay ready
after that. Subtitle decoding shouldn't take too long so it could be done
in such a "just in time" manner. The question is though if it will give us
any real performance upgrade.

The next step would be to make the subtitles work in xshm as well - this
would require to move the subtitle decoding from display to decoding time
so the subtitle overlay could be copied to the rgb buffer during the
yuv2rgb conversion.

Kepp up your great work,

   Guenter

[xine-devel] SPU fixed in CVS

[Rich Wareham <rjw57@ca...>]

As per subject line. Also added a brief section on subtitles in the README.

Rich

-- 
==================================================================
Rich Wareham <rjw57@...>
Robinson College, Cambridge, CB3 9AN

An exotic journey in downtown Newark is in your future.
==================================================================