Re: [xine-devel] Faster image decoding (was Re: [xine-cvs] CVS: xine-lib/src/libxinevdec gdkpixbuf.c,1.1,1.2)

[Reinhard N. <rn...@gm...>]

Hi,

Bastien Nocera wrote:

>>>>>> Upping the priority isn't enough, as the MNG demuxer as a "by
>>>>>> content"
>>>>>> check, and the image one doesn't. I'm trying to fix that now.
>>>>> All done.
>>>> Nice work. Thanks.
>>> I'm just not sure about that bit (which is probably wrong):
>>>         || (header[0] & 0xFFFF) == 0xffd8 /* another JPEG */
>> it's wrong, header[0] is a char, not a 32 bit unsigned value
>>
>>> which is supposed to check that equivalent in file's magic database:
>>> 0       beshort         0xffd8          JPEG image data
>> so the correct line should be something like :
>>          || (BE_16(&header[0]) == 0xffd8) /* another JPEG */
> 
> Looks better indeed. Thanks Thibaut.

Current CVS lacks support for BE_16():

demux_image.c:163: warning: implicit declaration of function 'BE_16'

load_plugins: probing demux 'image'
xine: symbol lookup error: 
/soft/xine-lib-cvs/lib/xine/plugins/1.1.2/xineplug_dmx_image.so: 
undefined symbol: BE_16

Bye.
-- 
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rn...@gm...